8000 Fix client crash without internet connection by EVAST9919 · Pull Request #367 · ppy/osu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix client crash without internet connection #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 20, 2017

Conversation

EVAST9919
Copy link
Contributor
@EVAST9919 EVAST9919 commented Feb 17, 2017

The crash happened when there's no internet connection and osu! trying to check updates.

}
else
catch(Exception e)

This comment was marked as off-topic.

@peppy
Copy link
Member
peppy commented Feb 19, 2017

Is there a way to do this without all these references? I'm pretty sure at very least the BCL one is not required (as it is a compatibility layer for <4.5). We should only need System.Net.Http.

@peppy peppy merged commit 9e1a3b5 into ppy:master Feb 20, 2017
@EVAST9919 EVAST9919 deleted the connection_fix branch February 20, 2017 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0