8000 Keep multiplayer settings open during room updates by smoogipoo · Pull Request #32923 · ppy/osu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Keep multiplayer settings open during room updates #32923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2025
Merged

Keep multiplayer settings open during room updates #32923

merged 2 commits into from
Apr 23, 2025

Conversation

smoogipoo
Copy link
Contributor
@smoogipoo smoogipoo commented Apr 23, 2025 •
edited
Loading

Supersedes / closes #32921

I explored the possibility of adding RoomJoined/RoomParted events, but it's a bit more involved because the room is sometimes already joined when entering the screen. Want to avoid bindables as much as possible.

@smoogipoo smoogipoo added area:multiplayer next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! labels Apr 23, 2025
@smoogipoo smoogipoo mentioned this pull request Apr 23, 2025
Closed
@smoogipoo smoogipoo requested a review from a team April 23, 2025 07:13
@bdach bdach self-requested a review April 23, 2025 07:31
bdach
bdach approved these changes Apr 23, 2025
View reviewed changes
Copy link
Collaborator
@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely prefer this one over that one

8000

@bdach bdach merged commit 059f6ef into ppy:master Apr 23, 2025
8 of 10 checks passed
@ShikkesoraSIM
Copy link

looks great and fixes the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
area:multiplayer next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smoogipoo @ShikkesoraSIM @bdach
0