Rename song select v2 classes and namespaces #32818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aims to bring some conformity to naming to make it easier to understand component structure for new components. Renames are pulled out of the song select v2 changes and are more relevant there due to many new classes being added. - `V2` suffix is dropped, with v2 components being moved to a relevant V2 namespace. - Related classes have a prefix of the area they are used. - Experimenting with using partial/nested classes in the song select v2 implementation. Not committing to this yet but want to see how it plays out. - Moved base carousel components to a generic namespace to avoid confusion with actual beatmap carousel implementation.
1 task
bdach
approved these changes
Apr 16, 2025
| { | ||
| public partial class LeaderboardScoreV2 : OsuClickableContainer, IHasContextMenu, IHasCustomTooltip<ScoreInfo> | ||
| public partial class BeatmapLeaderboardScore : OsuClickableContainer, IHasContextMenu, IHasCustomTooltip<ScoreInfo> |
There was a problem hiding this comment.
Don't really get this one, this was LeaderboardScoreV2 to distinguish against old-song-select LeaderboardScore, so kinda not sure what's with the Beatmap qualifier here. Also note that this is used in daily challenge.
Not hugely fussed though, probably can stay. I'd hope the old LeaderboardScore can be old yeller'd at some point because it's pretty horrific with the way it's been contorted to fit playlists.
There was a problem hiding this comment.
Not sure why Beatmap was added here, I'm fine to drop that if it makes things better.
There was a problem hiding this comment.
Let's just go with it as is.
There was a problem hiding this comment.
I guess it was kind of there to group this in follow-up work:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to bring some conformity to naming to make it easier to understand component structure for new components.
Renames are pulled out of the song select v2 changes and are more relevant there due to many new classes being added.
V2suffix is dropped, with v2 components being moved to a relevant V2 namespace.I'm open to any proposals here (if anything in this PR is seem as odd or unwanted, I'll probably cave to any/all requests). Just trying to set a base for moving forward from more efficiently.
One file in the diff looks like a new addition unfortunately, and that's due to the partial/nested class application.