Add shear-aligning drawable wrapper #32841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
762bf8f to
f480765
Compare
This was referenced Apr 18, 2025
I think you mean "right"? |
peppy
approved these changes
Apr 22, 2025
|
Right I mixed it up, previous implementation applied padding from the right, now it's from the left instead, as one logically expects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation has been slightly altered to make sense. The version in the above PR was applying padding from the left instead, and there's a reason behind that and why it works but I can understand that it's counter-intuitive (and/or completely backwards).
The purpose of this component is to be able to align multiple drawables in a vertical line while each one has sheared background and the sheared background is aligned correctly at the end.
Demonstrative video:
CleanShot.2025-04-18.at.06.27.52.mp4