8000 Autosave edited skin on change by bdach · Pull Request #28030 · ppy/osu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Autosave edited skin on change #28030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Autosave edited skin on change #28030

merged 2 commits into from
Apr 29, 2024

Conversation

bdach
Copy link
Collaborator
@bdach bdach commented Apr 29, 2024

Closes #26829.

Absolute barebones implementation, no dialogs or anything.

Not sure about the test, initially wanted it to exercise a gameplay scenario, but for whatever reason my attempt at doing so could not pass headless, and I tried for the better part of an hour.

8000
@peppy peppy self-requested a review April 29, 2024 13:42
@peppy peppy merged commit 0c45a48 into ppy:master Apr 29, 2024
@bdach bdach deleted the save-skin-on-change branch April 30, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing skin while skin editor is open causes changes to be lost
2 participants
0