Reduce allocations when ModSelectOverlay is visible
#27366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| master | pr |
|---|---|
ModSelectOverlay is visible
peppy
reviewed
Feb 25, 2024
| float rightEdgeOfLastButton = footerButtonFlow.Last().ScreenSpaceDrawQuad.TopRight.X; | ||
| ShearedButton lastFooterButton = null!; | ||
|
|
||
| foreach (var b in footerButtonFlow) |
There was a problem hiding this comment.
This is appalling legibility.
Surely we can at least use footerButtonFlow[^1].
peppy
reviewed
Feb 26, 2024
| private ICollection<ModPanel>? latestLoadedPanels; | ||
| internal bool ItemsLoaded => latestLoadTask?.IsCompleted == true && latestLoadedPanels?.All(panel => panel.Parent != null) == true; | ||
| private ModPanel[]? latestLoadedPanels; | ||
| internal bool ItemsLoaded => latestLoadTask?.IsCompleted == true && allPanelsLoaded; |
There was a problem hiding this comment.
After switching to array, you should be able to use static predicate without allocs and avoid yawn methods.
Suggested change
| internal bool ItemsLoaded => latestLoadTask?.IsCompleted == true && allPanelsLoaded; | |
| internal bool ItemsLoaded => latestLoadTask?.IsCompleted == true && latestLoadedPanels?.All(static panel => panel.Parent != null) == true; |
There was a problem hiding this comment.
Well...
And yes, I made sure I use static.
That's another case of LINQ methods accepting IEnumerable instead of provided type.
Same as in #27364 (comment)
peppy
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.