Add ability to calculate legacy scores with scorev1 #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanriders
requested changes
Jun 30, 2025
| RelativeSizeAxes = Axes.X, | ||
| Width = 0.25f, | ||
| Anchor = Anchor.TopLeft, | ||
| Label = "Is legacy score?", |
There was a problem hiding this comment.
I think it'd be better if we just assumed that if score field is populated then its a legacy score, and if not it's a lazer score.
There was a problem hiding this comment.
I think it's too implicit and unintuitive
| @@ -869,6 +883,26 @@ private void updateAccuracyParams(bool useFullScoreData) | |||
| } | |||
| } | |||
|
|
|||
| private void updateScoreTextBox() | |||
| { | |||
| if (ruleset.Value.ShortName == "osu" && legacyScoreSwitchButton.Current.Value) | |||
There was a problem hiding this comment.
Maybe show score textbox if CL is enabled instead, legacy scores can't be without CL
There was a problem hiding this comment.
There can be lazer scores with CL
There was a problem hiding this comment.
Those won't have scorev1
There was a problem hiding this comment.
That's why I'm using legacy score switch instead of CL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.