8000 feat: build multi-architecture docker images by gilbsgilbs · Pull Request #268 · powerman/dockerize · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: build multi-architecture docker images #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

A 8000 lready on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2023
Merged

feat: build multi-architecture docker images #268

merged 2 commits into from
Feb 28, 2023

Conversation

gilbsgilbs
Copy link
Contributor

Currently, only amd64 docker image is built. This commit builds a multi-architecture image and supports many different linux platforms.

Note that I wasn't able to test this. I'm moderately confident that it'll work first try.

@gilbsgilbs gilbsgilbs requested a review from powerman as a code owner February 28, 2023 19:32
@gilbsgilbs gilbsgilbs force-pushed the build-docker-multiarch branch from a7b5bc9 to 37a69cd Compare February 28, 2023 19:34
@powerman
Copy link
Owner

I'm going to make a release first, and play with this PR a bit later, because it's harder to test.

@powerman
Copy link
Owner

Well, locally it builds, so… let's try it.

@powerman powerman merged commit 608e20c into powerman:master Feb 28, 2023
@powerman
Copy link
Owner

The problem is build hangs.
I had same issue on my first try to build it locally, but restart helps and was fast because of using local docker cache.
Restarting on CI doesn't reuse local docker cache for obvious reason, and maybe this somehow related to hang reason.
I'll now re-run CI for the third time, just in case, but it looks like I'll have to revert this commit until you (or someone else) will be able to fix the hang. 😞
One random guess - it may be related to github throttling Go modules download: each arch's build tries to fetch same Go modules from github in parallel. Maybe using shared docker cache mounted to Go cache dir helps here, or maybe pre-build step with go mod download helps… But I don't have time to play with this (and I'm unsure there are enough real users for these docker images anyway).

@gilbsgilbs
Copy link
Contributor Author

Cross-building images can be very slow, but I'm not even able to see the logs of the hanging step. So I don't know if it's actually doing something or not 🤔. Can you access the logs by any chance?

@gilbsgilbs
Copy link
Contributor Author

Yeah, it was just slow, but was eventually successful: https://github.com/powerman/dockerize/actions/runs/4297435102/jobs/7490823537 .

The latest tag is multi-arch: https://hub.docker.com/layers/powerman/dockerize/latest/images/sha256-b70b7c0850b76cdbaf67294ac81249ca64aee521c7cc0169e485af84cb305861 🎉

@powerman
Copy link
Owner

18 minutes… Okay, let's hope it wasn't hang, just I was too impatient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerman powerman Awaiting requested review from powerman powerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilbsgilbs @powerman
0