You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a new plugin that enables automatic query refetching when data becomes stale. This provides a simple way to keep data fresh without manual intervention.
Features
Automatically refreshes queries when their staleTime is reached
Can be enabled/disabled globally via plugin options
Can be controlled per-query via autoRefetch option
Cleans up properly when queries are unmounted
Only runs on the client side
Issues and Questions
I am having an issue with one of the tests. To be honest, I am not good with writing tests (this is one of the rare cases where I've written one). So some help would be great!
The refetch timeout is currently set in refresh hook. I also tried fetch but the issue was fetch is not triggered on initial page load but refresh does. So even if the user does nothing regarding the query from initial load, it will be auto-fetched in the background.
To trigger a refresh, I've used queryCache.refresh(entry). I noticed there are also options like fetch, invalidate, and invalidateQueries. I used refresh because I understand it has an internal check on the data to see if it is fresh. I did not want to force it with fetch.
The refetch timeouts are only set on the client. I think this should be the expected behavior, as otherwise the refetch keeps happening on the server, too.
I would love your feedback on this. I am happy to work on this further.
There should also be another test that ensures the timer is reset if a new request is fired before the data becomes stale
Thank you @posva! I've added a new test for this and also accepted & implemented your suggestions. However, two tests are failing:
it automatically refetches when stale time is reached
it resets the stale timer when a new request occurs
In both cases, it seems the query was called one less time than expected. I tried to set stale time to 1ms or advancing time by 10000ms but the number of queries remain the same, so I think something in my tests are wrong but I cannot figure out what exactly. Tried using fetch instead of refresh in the plugin but that also did not work. Would you have any ideas?
All done! The only issue left is the it resets the stale timer when a new request occurs test, which I am not able to pass despite clearing timeouts before scheduling the refetch and at the time of the refetch.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49.
This PR adds a new plugin that enables automatic query refetching when data becomes stale. This provides a simple way to keep data fresh without manual intervention.
Features
Issues and Questions
refreshhook. I also triedfetchbut the issue wasfetchis not triggered on initial page load butrefreshdoes. So even if the user does nothing regarding the query from initial load, it will be auto-fetched in the background.queryCache.refresh(entry). I noticed there are also options likefetch,invalidate, andinvalidateQueries. I usedrefreshbecause I understand it has an internal check on the data to see if it is fresh. I did not want to force it withfetch.I would love your feedback on this. I am happy to work on this further.