Support fractional height/width/offset values in bar configuration #953
Labels
Comments
jonhoo
added a commit
to jonhoo/polybar
that referenced
this issue
Jan 21, 2018
jonhoo
added a commit
to jonhoo/polybar
that referenced
this issue
Feb 11, 2018
jonhoo
added a commit
to jonhoo/polybar
that referenced
this issue
Feb 11, 2018
jonhoo
added a commit
to jonhoo/polybar
that referenced
this issue
Feb 15, 2018
jonhoo
added a commit
to jonhoo/polybar
that referenced
this issue
Feb 25, 2018
jonhoo
added a commit
to jonhoo/polybar
that referenced
this issue
Mar 12, 2018
jonhoo
added a commit
to jonhoo/polybar
that referenced
this issue
Mar 22, 2018
NBonaparte
pushed a commit
that referenced
this issue
Mar 28, 2018
patrick96
added a commit
that referenced
this issue
Jul 23, 2018
Breaking Changes: * `0 < label-NAME-maxlen < 3` will now throw an exception and disable the containing module, if ellipsis is enabled for that label. (#1198) Changelog: Deprecations: * `internal/volume` is now called `internal/alsa` (#967) * temperature: The `%temperature%` is deprecated in favor of `%temperature-c%`(#897) * mpd: `icon-repeatone` is deprecated in favor of `icon-single` (#1295), see #1279 Features: * feat(mpd): Add support for icon-consume (#861) * feat(bspwm): Add workspace separator (#942) * feat(i3): Add workspace separator (#938), see #929 * feat(build): Make polybar build on FreeBSD (#931, polybar/xpp#8), see #239 * feat(volume): Add pulseaudio backend (#779) * feat(script): Add %pid% token for tail commands (#934) * feat(temp): Add temperature tokens without unit (#897) * feat(memory): Add memory used/free ramp (#1038), see #1037 * feat(memory): Add swap tokens (#1018) * feat(net): Add unknown-as-up option (#1077), see #457 * feat(config): Support fractional size and offset (#972), see #953 * feat(xwindow): Add label-empty (#1136) * feat(battery): Add animation-discharging (analog to animation-charging) (#1190) * feat(config): Support pixel offset for bar size and offset values (#1224) * feat(mpd): Add `%album-artist%` token (#1263) * feat(net): Add local_ip6 token (#1239), see #1234 * feat(net): Add nl80211 support (#1009), see #277 Fixes: * fix(mpd): Wrong elapsed time when after standby (#921), see #915 * fix(config): Wrong min, maxlen when using the same token multiple times (#974), see #971 * fix(battery): use power_now correctly (#958), see #928 * fix(mpd): Crash when mpd isn't running (#983), see #979 * fix(xworkspaces): Respect 'enable-scroll' (#1002) * fix(xbacklight): Respect 'enable-scroll' (#1014) * fix(build): support xcb-proto >=1.13 (polybar/xpp#11), see #973 * fix(mpd): Respect MPD_HOST env variable (#1025), see #1007 * fix(i3): Reconnect i3 IPC socket on restart/error (#1099), see #762 * fix(cursor): Occasional crash on mouseover (#1124), see #1117 * fix(net): Mark 'not connected' on querying failure (#1171), see #1163 * fix(gcc): Fix -Wstringop-truncation warning (#1216, polybar/i3ipcpp#7), see #1215 * fix(builder): Don't truncate colors with same channels (#1217), see #1183 * fix(bspwm): Consistent behavior when scrolling through multiple desktops (#986), see #981 * fix(builder): Respect label-ellipsis option (#1198), see #1194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bar height, width, and offset-x/y are all currently configured either "as pixel value (e.g. 35) or percentage (e.g. 50%)". However, if a percentage value is given, only integer percentages can be used due to the use of
intherehttps://github.com/jaagr/polybar/blob/0a5ad9c76fe3f966b7f9f2fabfabea1a8eba05d5/src/components/bar.cpp#L251-L262
Unless there is a particularly good reason for this, I suggest this code be changed to allow fractional percentages to enable allows finer control. This is valuable in settings where an absolute value is not desired (e.g., when working with different DPIs; see #951).
The text was updated successfully, but these errors were encountered: