8000 Cannot compile latest version · Issue #344 · polybar/polybar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cannot compile latest version #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Jan 15, 2017 · 20 comments
Closed

Cannot compile latest version #344

ghost opened this issue Jan 15, 2017 · 20 comments

Comments

@ghost
Copy link
ghost commented Jan 15, 2017

I cannot compile the latest version and I don't know why.

Using Ubuntu 16.04

Build log: http://pastebin.com/rwRuW5R9
@taylorthurlow taylorthurlow mentioned this issue Jan 15, 2017
Closed
@ChoiZ
Copy link
ChoiZ commented Jan 15, 2017

During debugging I use this package:
https://www.ubuntuupdates.org/package/getdeb_apps/yakkety/apps/getdeb/polybar

But there is no i3 support 👎

@ghost
Copy link
Author
ghost commented Jan 15, 2017

Yeah, I installed that too, but it is an older version too.

@jaagr
Copy link
Member
jaagr commented Jan 17, 2017

Disable XRandR monitor support and it should work:

$ cmake -DENABLE_XRANDR_MONITORS=0 ..

@ChoiZ
Copy link
ChoiZ commented Jan 17, 2017

It's works like a charm. Thanks @jaagr.

@jaagr jaagr closed this as completed Jan 20, 2017
@ghost
Copy link
Author
ghost commented Jan 21, 2017

Will you update the build script with randr disabled?

@jaagr
Copy link
Member
jaagr commented Jan 23, 2017

@alekcacko what build script?

@ghost
Copy link
Author
ghost commented Jan 25, 2017

Your build.sh?

@jaagr
Copy link
Member
jaagr commented Jan 25, 2017

cmake should disable it if the xrandr version is too old.. what does this command print?

$ pkg-config xrandr ">= 1.5.0" --print-provides

@IrishPrime
Copy link

On Fedora 24, had the same issue with commit 9d589fa5a71f081aecfa455a9996904e458c8cfa.

$ pkg-config xrandr ">= 1.5.0" --print-provides
xrandr = 1.5.1

@jaagr
Copy link
Member
jaagr commented Jan 25, 2017

@IrishPrime Could you pastebin CMakeCache.txt in your build dir

@jaagr
Copy link
Member
jaagr commented Jan 25, 2017

And could you also check:

$ pkg-config randrproto ">= 1.5.0" --print-provides

jaagr added a commit that referenced this issue Jan 25, 2017
@jaagr
fix(cmake): Require randproto>=1.5 for monitor support
017abee 
Refs #344
@IrishPrime
Copy link

CMakeCache.txt

pkg-config randrproto ">= 1.5.0" --print-provides
randrproto = 1.5.0

@jaagr
Copy link
Member
jaagr commented Jan 25, 2017

Can't see how you can get the error with ENABLE_XRANDR_MONITORS:UNINITIALIZED=0

@IrishPrime
Copy link

Yeah, I just realized that. I stupidly made the paste from my most recent build (using the workaround). Here's a failing one from the latest commit.
8000

@jaagr
Copy link
Member
jaagr commented Jan 25, 2017 •
edited
Loading

This is probably why: XCBPROTO_VERSION:INTERNAL=1.11.. It requires 1.12 if I'm not mistaken. Will add a check for that as well.

jaagr added a commit that referenced this issue Jan 25, 2017
@jaagr
fix(cmake): Require xcb-proto>=1.12 for monitor support
8fa879c 
Refs #344
jaagr added a commit that referenced this issue Jan 27, 2017
@jaagr
fix(cmake): Require xcb-randr>=1.12 for monitors
2912f0f 
Refs #344
@hidde-jan
Copy link

This is still a problem on ubuntu 16.04. I've tried all different variations of -DWITH_XRANR_MONITORS (and -DENABLE_XRANDR_MONITORS) I found floating around the different issues, but cmake still tries to build with xrandr support.

@florianbaer
Copy link
florianbaer commented Oct 9, 2018 •
edited
Loading

Was this CMAKE parameter renamed? Is it now called WITH_XRANDR_MONITORS? Can somebody verify this?

@patrick96
Copy link
Member

Yeah it was changed 43a17c3, it's now called WITH_XRANDR_MONITORS

@phiho1609
Copy link

I take no responsibilty, if sth about this fix destroys anything. Trying at ur own risk:

So i had the same problem. Ubuntu 17.xx, polybar, and every try to make randr.cpp was throwing the error, that (i think it was) .get_monitors or sth, is not known, and everything stopped. I tried every Tag i could find (WITH_XRANDR_MONITORS, DENABLE_XRANDR_MONITORS...), nothing worked. So i found a not great, but at least working workaround. I searched for the randr.cpp file in the polybar directory. I opened the code and searched for the part where it said something like #if <SOME_XRANDR_TAG_SEEN_ABOVE> (i cant remember which tag it exactly was, but it was one of the above mentioned and at the lower part of the file). So i just commented the code which is in the #if part out with /* if part */.

Because the part which should not be executed, was somehow still accepted as used code, i made it unused manually.

After that make the whole thing just with cmake .. (dont even have to use a tag, because code isnt active anymore), and it should work. When i execute the example bar, i get some errors and warnings, which seem not directly related to the 'fix', but maybe they are in some way, i just dont know.

Maybe it will help you as much as it did for me.

@patrick96
Copy link
Member

@phiho1609 seems like that issue is related to #1437. The fix for it is already up for review, it's basically the same as your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@IrishPrime @hidde-jan @ChoiZ @patrick96 @florianbaer @jaagr @phiho1609
0