chore: display prices as full number on sales page #11554
Conversation
There was a problem hiding this comment.
I would suggest creating a new helper function outside the component and making use of it.
const helper = (num: BN) => `${(num.toNumber() / 10 ** formatBalance.getDefaults().decimals)} ${formatBalance.getDefaults().unit}`;and use it like:
const formattedCoretimePrice = useMemo(() => {
return !coretimePrice ? null : helper(coretimePrice);
}, [coretimePrice])Similarly, use it with startPrice and endPrice as well. This makes the code cleaner and more readable.
That makes sense. I'll make the requested changes. |
|
@ap211unitech I’ve made the suggested change in 404698b. Also, the Sale Timeline box looked cluttered when the price value was large on smaller screens, so I updated the layout to a 2×3 grid to improve readability. Here’s how it looks now on smaller screens: |
404698b to
ad590ab
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
fixes #11465
Previous behaviour
Current behaviour (updated)