10000 chore: fixed bug on chart and ui issue in sale page by Ernesto-tha-great · Pull Request #11354 · polkadot-js/apps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: fixed bug on chart and ui issue in sale page #11354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 7, 2025
Merged

chore: fixed bug on chart and ui issue in sale page #11354

merged 11 commits into from
Apr 7, 2025

Conversation

Ernesto-tha-great
Copy link
Contributor
@Ernesto-tha-great Ernesto-tha-great commented Mar 4, 2025 •
edited
Loading
  • Fixed issue in chart, using a custom function to fix the draw and after draw.
  • fixed the darkmode issue in the coretime/sale and also the whitebox component

@ap211unitech
Copy link
Member

Please resolve the lint issues using yarn lint and provide a description for the PR.

@Ernesto-tha-great
Copy link
Contributor Author

Please resolve the lint issues using yarn lint and provide a description for the PR.

All done!

@TarikGul TarikGul requested a review from piggydoughnut March 5, 2025 12:25
@TarikGul
Copy link
Member

cc: @piggydoughnut

@Ernesto-tha-great
Copy link
Contributor Author
Ernesto-tha-great commented Mar 27, 2025 •
edited
Loading

@piggydoughnut @ap211unitech

please take a look.

@ap211unitech
Copy link
Member

@Ernesto-tha-great Still needs yarn lint

@Ernesto-tha-great
Copy link
Contributor Author

@ap211unitech
apologies. all fixed now.

@ap211unitech
Copy link
Member

The sale page theme is not fixed yet.

image

@Ernesto-tha-great
Copy link
Contributor Author
Ernesto-tha-great commented Apr 7, 2025 •
edited
Loading

@ap211unitech
sales theme completely fixed and tested.

Screenshot 2025-04-07 at 03 55 32

ap211unitech
ap211unitech approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member
@ap211unitech ap211unitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks for your contribution :)

@ap211unitech ap211unitech merged commit 05eb5a2 into polkadot-js:master Apr 7, 2025
5 checks passed
@piggydoughnut
Copy link
Contributor

@ap211unitech notifications are completely lost on me, sorry about that :)

Looks good 👍🏽 nice job @Ernesto-tha-great

@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ap211unitech ap211unitech ap211unitech approved these changes

@piggydoughnut piggydoughnut Awaiting requested review from piggydoughnut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ernesto-tha-great @ap211unitech @TarikGul @piggydoughnut @polkadot-js-bot
0