-
Notifications
You must be signed in to change notification settings - Fork 2
POC integration with DemDis #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
patcon
wants to merge
10
commits into
main
Choose a base branch
from
demdis-implementation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement statistics).
Questions for DemDis folks:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a messy first-pass at providing output that DemDis could quickly swap into their system and compare.
The only changes I made in the function definition is adding a temporary
skip_remap
arg for testing. By skipping the remapping of votes from DemDis shape to the internal shape, this allows me to pass in Polis vote data, and avoid using votes with DemDis-specific keys and vote values (Demdis:agree
/skip
/disagree
strings. Polis:1
/0
/-1
ints that Red-Dwarf expects).cc: @beowulf11 @denis-capkovic-demdis @Sketchead63
Todos
run_clustering()
function with existing functionality from red-dwarfstatement_boost
argStatementConversationMetric
dataClusteredStatement
datacluster_defining_{pos,neg,skip}_coefficient
last_vote_at
in resultsrun_clustering()