8000 [ISSUE #1015] 修复熔断探测规则下发可能导致客户端刷日志的问题 by chuntaojun · Pull Request #1014 · polarismesh/polaris · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ISSUE #1015] 修复熔断探测规则下发可能导致客户端刷日志的问题 #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2023
Merged

[ISSUE #1015] 修复熔断探测规则下发可能导致客户端刷日志的问题 #1014

merged 1 commit into from
Mar 17, 2023

Conversation

chuntaojun
Copy link
Member
@chuntaojun chuntaojun commented Mar 17, 2023 •
edited
Loading

Please provide issue(s) of this PR:
Fixes #1015

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • ApiServer
  • Auth
  • Configuration
  • Naming
  • HealthCheck
  • Metrics
  • Docs
  • Installation
  • Performance and Scalability
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@chuntaojun chuntaojun changed the title fix:修复熔断探测规则下发可能导致客户端刷日志的问题 [ISSUE #1015] 修复熔断探测规则下发可能导致客户端刷日志的问题 Mar 17, 2023
andrewshan
andrewshan approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member
@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
codecov bot commented Mar 17, 2023

Codecov Report

Merging #1014 (3844650) into release-v1.15.0 (248df93) will increase coverage by 0.01%.
The diff coverage is 55.93%.

@@                 Coverage Diff                 @@
##           release-v1.15.0    #1014      +/-   ##
===================================================
+ Coverage            57.26%   57.28%   +0.01%     
===================================================
  Files                  190      190              
  Lines                34379    34379              
===================================================
+ Hits                 19688    19694       +6     
+ Misses               12120    12111       -9     
- Partials              2571     2574       +3
Impacted Files Coverage Δ
cache/service.go 82.00% <ø> (ø)
config/config_file.go 51.72% <ø> (ø)
config/config_file_group.go 38.41% <40.00%> (ø)
service/ratelimit_config.go 63.65% <43.75%> (ø)
service/client_v1.go 50.61% <50.00%> (+0.73%) ⬆️
store/mysql/config_file.go 54.00% <50.00%> (ø)
store/mysql/config_file_group.go 33.73% <50.00%> (ø)
store/mysql/config_file_release.go 58.62% <50.00%> (ø)
service/service.go 64.59% <60.00%> (ø)
service/instance.go 61.84% <68.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chuntaojun chuntaojun merged commit bb03f53 into polarismesh:release-v1.15.0 Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewshan andrewshan andrewshan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chuntaojun @andrewshan
0