8000 support specification, and add circuitbreaker rule and faultdetect rule feature by andrewshan · Pull Request #888 · polarismesh/polaris · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

support specification, and add circuitbreaker rule and faultdetect rule feature #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our te 8000 rms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 12, 2023
Merged

support specification, and add circuitbreaker rule and faultdetect rule feature #888

merged 11 commits into from
Jan 12, 2023

Conversation

andrewshan
Copy link
Member
@andrewshan andrewshan commented Jan 9, 2023 •
edited
Loading

Please provide issue(s) of this PR:
Fixes #831
Feats #893

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • ApiServer
  • Auth
  • Configuration
  • Naming
  • HealthCheck
  • Metrics
  • Docs
  • Installation
  • Performance and Scalability
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

andrewshan and others added 2 commits January 8, 2023 16:39
@andrewshan
Merge pull request #1 from polarismesh/main
4100749 
test:修复eureka集群测试场景相关配置 (#887)
@andrewshan
[WIP] support to depend on spec & new circuitbreaker rule spec
b6b72f4 
1. drop all proto, and move them into specification
2. add circuitbreaker and healthcheck rule
@andrewshan andrewshan requested a review from chuntaojun January 9, 2023 09:23
@polaris-test-bot
Copy link
polaris-test-bot commented Jan 9, 2023 •
edited
Loading

2023-01-09 17:23:59: =========TEST START==========
2023-01-09 17:24:30: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-01-09 17:39:49: [STANDALONE VERSION]PR autotest FAILED! We executed 20 test cases and 18 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/sta/qta-report.html
2023-01-09 17:39:53: [CLUSTER VERSION] PR autotest FAILED! We executed 20 test cases and 18 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/clu/qta-report.html
2023-01-09 17:39:56: [KUBENETES VERSION]PR autotest FAILED! We executed 20 test cases and 18 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/k8s/qta-report.html
2023-01-09 18:05:14: =========TEST START==========
2023-01-09 18:05:44: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-01-09 18:19:37: [STANDALONE VERSION]PR autotest FAILED! We executed 20 test cases and 17 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/sta/qta-report.html
2023-01-09 18:19:41: [CLUSTER VERSION] PR autotest FAILED! We executed 20 test cases and 18 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/clu/qta-report.html
2023-01-09 18:19:45: [KUBENETES VERSION]PR autotest FAILED! We executed 20 test cases and 18 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/k8s/qta-report.html
2023-01-09 18:31:20: =========TEST START==========
2023-01-09 18:31:49: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-01-09 18:45:48: [STANDALONE VERSION]PR autotest FAILED! We executed 20 test cases and 18 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/sta/qta-report.html
2023-01-09 18:45:51: [CLUSTER VERSION] PR autotest FAILED! We executed 20 test cases and 18 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/clu/qta-report.html
2023-01-09 18:45:55: [KUBENETES VERSION]PR autotest FAILED! We executed 20 test cases and 18 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/k8s/qta-report.html
2023-01-09 20:05:39: =========TEST START==========
2023-01-09 20:06:08: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-01-09 20:19:53: [STANDALONE VERSION]PR autotest FAILED! We executed 20 test cases and 18 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/sta/qta-report.html
2023-01-09 20:19:57: [CLUSTER VERSION] PR autotest FAILED! We executed 20 test cases and 18 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/clu/qta-report.html
2023-01-09 20:20:01: [KUBENETES VERSION]PR autotest FAILED! We executed 20 test cases and 18 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/k8s/qta-report.html
2023-01-10 16:27:53: =========TEST START==========
2023-01-10 16:28:27: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-01-10 16:43:02: [STANDALONE VERSION]PR autotest PASSED! We executed 20 test cases and 20 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/sta/qta-report.html
2023-01-10 16:43:07: [CLUSTER VERSION] PR autotest PASSED! We executed 20 test cases and 20 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/clu/qta-report.html
2023-01-10 16:43:12: [KUBENETES VERSION]PR autotest PASSED! We executed 20 test cases and 20 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/k8s/qta-report.html
2023-01-12 00:21:07: =========TEST START==========
2023-01-12 00:21:34: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-01-12 00:35:27: [STANDALONE VERSION]PR autotest PASSED! We executed 20 test cases and 20 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/sta/qta-report.html
2023-01-12 00:35:31: [CLUSTER VERSION] PR autotest PASSED! We executed 20 test cases and 20 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/clu/qta-report.html
2023-01-12 00:35:35: [KUBENETES VERSION]PR autotest PASSED! We executed 20 test cases and 20 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/k8s/qta-report.html
2023-01-12 10:04:11: =========TEST START==========
2023-01-12 10:04:38: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-01-12 10:17:05: =========TEST START==========
2023-01-12 10:17:34: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-01-12 10:20:26: =========TEST START==========
2023-01-12 10:20:54: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-01-12 10:34:31: [STANDALONE VERSION]PR autotest PASSED! We executed 20 test cases and 20 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/sta/qta-report.html
2023-01-12 10:34:35: [CLUSTER VERSION] PR autotest PASSED! We executed 20 test cases and 20 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/clu/qta-report.html
2023-01-12 10:34:39: [KUBENETES VERSION]PR autotest PASSED! We executed 20 test cases and 20 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1190453239/k8s/qta-report.html

chuntaojun
chuntaojun reviewed Jan 10, 2023
View reviewed changes
@codecov
Copy link
codecov bot commented Jan 10, 2023 •
edited
Loading

Codecov Report

Merging #888 (8d91982) into main (3a23bdb) will decrease coverage by 1.80%.
The diff coverage is 53.78%.

@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
- Coverage   55.91%   54.10%   -1.81%     
==========================================
  Files         174      182       +8     
  Lines       30888    33232    +2344     
==========================================
+ Hits        17270    17980     +710     
- Misses      11357    12827    +1470     
- Partials     2261     2425     +164
Impacted Files Coverage Δ
auth/defaultauth/server_authability.go 80.00% <0.00%> (ø)
cache/instance.go 74.77% <0.00%> (ø)
common/model/acquire_context.go 86.07% <ø> (ø)
common/model/client.go 26.08% <ø> (ø)
common/model/instance.go 56.09% <ø> (ø)
common/model/naming.go 66.42% <ø> (+0.99%) ⬆️
common/model/operation.go 100.00% <ø> (ø)
common/model/routing.go 51.72% <ø> (ø)
config/client_config_file.go 45.26% <ø> (-1.48%) ⬇️
config/client_config_file_authibility.go 50.00% <ø> (ø)
... and 155 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chuntaojun
Copy link
Member

Screenshot 2023-01-11 at 11 45 16

这里的 typeUrl ，两个保证一样吗？不一样的话，存量会有问题

chuntaojun
chuntaojun reviewed Jan 11, 2023
View reviewed changes
@andrewshan
Copy link
Member Author

Screenshot 2023-01-11 at 11 45 16

这里的 typeUrl ，两个保证一样吗？不一样的话，存量会有问题

这边验证了，存数据库的二进制是不带url的，url是程序在反序列化的时候加入的，反序列化二进制的时候不依赖url，所以存量数据加载不会有问题

@chuntaojun chuntaojun changed the title [WIP] support specification, and add circuitbreaker rule and faultdetect rule feature support specification, and add circuitbreaker rule and faultdetect rule feature Jan 12, 2023
@chuntaojun chuntaojun merged commit f862283 into polarismesh:main Jan 12, 2023
This was linked to issues Jan 12, 2023
support instance and method circuitbreaker rule, and health check detect rule #893
Closed
服务协议统一使用specification定义的协议 #841
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuntaojun chuntaojun chuntaojun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@andrewshan @polaris-test-bot @chuntaojun
0