8000 fix: eureka同步时，实例不存在没有返回404，导致eureka触发不了重注册 by andrewshan · Pull Request #835 · polarismesh/polaris · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: eureka同步时，实例不存在没有返回404，导致eureka触发不了重注册 #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 1, 2022
Merged

fix: eureka同步时，实例不存在没有返回404，导致eureka触发不了重注册 #835

merged 3 commits into from
Dec 1, 2022

Conversation

andrewshan
Copy link
Member
@andrewshan andrewshan commented Dec 1, 2022 •
edited
Loading

Please provide issue(s) of this PR:
Fixes #834

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Installation
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@codecov
Copy link
codecov bot commented Dec 1, 2022

Codecov Report

Merging #835 (f53a1b3) into release-v1.13.0 (7cf50ca) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release-v1.13.0     #835   +/-   ##
================================================
  Coverage            57.18%   57.18%           
================================================
  Files                  161      161           
  Lines                28867    28867           
================================================
  Hits                 16507    16507           
- Misses               10162    10165    +3     
+ Partials              2198     2195    -3
Impacted Files Coverage Δ
cache/routing_config.go 64.51% <0.00%> (-1.21%) ⬇️
store/boltdb/routing.go 51.66% <0.00%> (-0.74%) ⬇️
store/sqldb/routing_config_v2.go 51.40% <0.00%> (+1.40%) ⬆️
cache/ratelimit_config.go 81.67% <0.00%> (+1.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chuntaojun chuntaojun added bug Something isn't working service Service registration discovery, service governance labels Dec 1, 2022
@chuntaojun chuntaojun merged commit 10e0a43 into polarismesh:release-v1.13.0 Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working service Service registration discovery, service governance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewshan @chuntaojun
0