10000 fix-shellcheck(SC1128) The shebang must be on the first line. by dyrnq · Pull Request #815 · polarismesh/polaris · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix-shellcheck(SC1128) The shebang must be on the first line. #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy st 8000 atement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2022
Merged

fix-shellcheck(SC1128) The shebang must be on the first line. #815

merged 1 commit into from
Nov 23, 2022

Conversation

dyrnq
Copy link
Contributor
@dyrnq dyrnq commented Nov 22, 2022 •
edited
Loading

The shebang must be on the first line. Delete blanks and move comments.shellcheck(SC1128) #814

A shebang only has an effect when it appears as the first line in a script. Specifically, the first two bytes of the file must be #!.

More external link see https://www.shellcheck.net/wiki/SC1128

Please provide issue(s) of this PR:
Fixes #814

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Installation
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@dyrnq
fix-shellcheck(SC1128) The shebang must be on the first line.
6de6c70 
The shebang must be on the first line. Delete blanks and move comments.shellcheck(SC1128) polarismesh#814

A shebang only has an effect when it appears as the first line in a script. Specifically, the first two bytes of the file must be #!.

More external link see <https://www.shellcheck.net/wiki/SC1128>
@polaris-test-bot
Copy link
polaris-test-bot commented Nov 22, 2022 •
edited
Loading

2022-11-22 18:51:29: =========TEST START==========
2022-11-22 18:51:53: Pre-Merge check fail! This branch has conflicts that must be resolved. After the conflict is resolved, we will continue to execute the test.

@codecov
Copy link
codecov bot commented Nov 23, 2022

Codecov Report

Merging #815 (6de6c70) into main (43d27bf) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #815   +/-   ##
=======================================
  Coverage   57.06%   57.07%           
=======================================
  Files         161      161           
  Lines       28845    28845           
=======================================
+ Hits        16461    16463    +2     
+ Misses      10180    10179    -1     
+ Partials     2204     2203    -1
Impacted Files Coverage Δ
store/sqldb/routing_config_v2.go 50.00% <0.00%> (-1.41%) ⬇️
cache/ratelimit_config.go 81.67% <0.00%> (+1.52%) ⬆️
cache/config_file.go 72.82% <0.00%> (+1.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chuntaojun chuntaojun merged commit d100faa into polarismesh:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The shebang must be on the first line. Delete blanks and move comments.shellcheck(SC1128)
3 participants
@dyrnq @polaris-test-bot @chuntaojun
0