8000 Feature: improve code and improve golangci-lint config by houseme · Pull Request #777 · polarismesh/polaris · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature: improve code and improve golangci-lint config #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and pr 8000 ivacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 1, 2022
Merged

Feature: improve code and improve golangci-lint config #777

merged 15 commits into from
Nov 1, 2022

Conversation

houseme
Copy link
Member
@houseme houseme commented Oct 30, 2022

Please provide issue(s) of this PR:
Fixes #776

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Installation
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@codecov
Copy link
codecov bot commented Oct 30, 2022 •
edited
Loading

Codecov Report

Merging #777 (baa02a7) into main (59e25af) will decrease coverage by 0.30%.
The diff coverage is 76.82%.

@@            Coverage Diff             @@
##             main     #777      +/-   ##
==========================================
- Coverage   57.28%   56.97%   -0.31%     
==========================================
  Files         159      159              
  Lines       29022    28777     -245     
==========================================
- Hits        16624    16397     -227     
+ Misses      10188    10175      -13     
+ Partials     2210     2205       -5
Impacted Files Coverage Δ
auth/defaultauth/strategy.go 66.71% <ø> (-0.05%) ⬇️
auth/defaultauth/utils.go 67.61% <ø> (-0.31%) ⬇️
cache/config_file.go 72.82% <ø> (-3.40%) ⬇️
cache/routing_config.go 65.72% <ø> (-0.41%) ⬇️
cache/routing_config_bucket.go 66.83% <ø> (-0.17%) ⬇️
cache/service.go 83.39% <ø> (-0.13%) ⬇️
cache/store_time.go 62.50% <ø> (-1.50%) ⬇️
cache/test_export.go 33.33% <0.00%> (ø)
common/model/naming.go 70.83% <ø> (-0.89%) ⬇️
config/client_config_file.go 46.73% <ø> (-0.14%) ⬇️
... and 89 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chuntaojun
Copy link
Member

pls fix ci

@chuntaojun chuntaojun added code quality Prompt code readability, reduce repetitive code, improve code maintainability, code comment github-action github-action labels Oct 31, 2022
@houseme
Copy link
Member Author
houseme commented Oct 31, 2022

pls fix ci

已处理

chuntaojun
chuntaojun suggested changes Oct 31, 2022
View reviewed changes
@houseme houseme requested a review from chuntaojun October 31, 2022 09:32
@chuntaojun chuntaojun merged commit 16747af into polarismesh:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuntaojun chuntaojun chuntaojun approved these changes

Assignees
No one assigned
Labels
code quality Prompt code readability, reduce repetitive code, improve code maintainability, code comment github-action github-action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve code and improve golangci-lint config
2 participants
@houseme @chuntaojun
0