8000 fix: 鉴权插件优化(#709) by alexwanglei · Pull Request #771 · polarismesh/polaris · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: 鉴权插件优化(#709) #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2022
Merged

fix: 鉴权插件优化(#709) #771

merged 1 commit into from
Nov 1, 2022

Conversation

alexwanglei
Copy link
Contributor

chuntaojun
chuntaojun suggested changes Oct 26, 2022
View reviewed changes
@codecov
Copy link
codecov bot commented Oct 26, 2022 •
edited
Loading

Codecov Report

Merging #771 (3941ea9) into main (dd9d155) will decrease coverage by 0.55%.
The diff coverage is 92.68%.

❗ Current head 3941ea9 differs from pull request most recent head 4444f99. Consider uploading reports for the commit 4444f99 to get more accurate results

@@            Coverage Diff             @@
##             main     #771      +/-   ##
==========================================
- Coverage   56.95%   56.40%   -0.56%     
==========================================
  Files         159      159              
  Lines       28777    29009     +232     
==========================================
- Hits        16391    16363      -28     
- Misses      10179    10479     +300     
+ Partials     2207     2167      -40
Impacted Files Coverage Δ
auth/defaultauth/auth_mgn.go 55.17% <ø> (+2.23%) ⬆️
auth/defaultauth/utils.go 67.61% <ø> (ø)
common/model/acquire_context.go 86.07% <ø> (-0.99%) ⬇️
config/server_authability.go 80.48% <ø> (-0.62%) ⬇️
plugin/plugin.go 66.66% <ø> (ø)
plugin/whitelist.go 0.00% <0.00%> (ø)
service/default.go 20.96% <ø> (-0.25%) ⬇️
service/server.go 40.00% <ø> (+0.29%) ⬆️
service/server_authability.go 84.67% <ø> (-0.07%) ⬇️
service/utils.go 13.95% <ø> (+0.91%) ⬆️
... and 83 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alexwanglei alexwanglei force-pushed the fix/optimize_auth_plugin branch from c8e2632 to d217724 Compare October 26, 2022 12:29
chuntaojun
chuntaojun reviewed Oct 27, 2022
View reviewed changes
@alexwanglei alexwanglei force-pushed the fix/optimize_auth_plugin branch 3 times, most recently from 317af43 to e220ea9 Compare October 27, 2022 03:30
@alexwanglei alexwanglei marked this pull request as ready for review October 27, 2022 06:09
chuntaojun
chuntaojun reviewed Oct 27, 2022
View reviewed changes
< 8000 /details-collapsible>
@alexwanglei alexwanglei force-pushed the fix/optimize_auth_plugin branch from e220ea9 to 3941ea9 Compare October 27, 2022 11:31
@chuntaojun
Copy link
Member

LGTM

@chuntaojun chuntaojun added enhancement New feature or request auth auth module labels Oct 27, 2022
@chuntaojun chuntaojun added this to the v1.13.0 milestone Oct 27, 2022
@chuntaojun chuntaojun added the plugin polaris-server plugin label Oct 29, 2022
@chuntaojun
Copy link
Member

pls fix code conflict

@alexwanglei alexwanglei force-pushed the fix/optimize_auth_plugin branch from 3941ea9 to e9585ca Compare November 1, 2022 03:37
fix: 鉴权插件优化(polarismesh#709)
4444f99 
* fix issue polarismesh#709

* AcquireContext移除token成员和WithToken方法

* 鉴权token获取在鉴权模块的权限检查中进行

* 去掉plugin/auth鉴权插件，迁移整合到auth/defaultauth中

* 增加whitelist插件
@alexwanglei alexwanglei force-pushed the fix/optimize_auth_plugin branch from e9585ca to 4444f99 Compare November 1, 2022 05:45
@chuntaojun chuntaojun merged commit f6aae61 into polarismesh:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuntaojun chuntaojun chuntaojun approved these changes

Assignees
No one assigned
Labels
auth auth module enhancement New feature or request plugin polaris-server plugin
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexwanglei @chuntaojun
0