8000 perf(annotate): 优化代码注释内容 by lbbniu · Pull Request #667 · polarismesh/polaris · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

perf(annotate): 优化代码注释内容 #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2022
Merged

perf(annotate): 优化代码注释内容 #667

merged 2 commits into from
Sep 24, 2022

Conversation

lbbniu
Copy link
Contributor
@lbbniu lbbniu commented Sep 15, 2022 •
edited
Loading

Please provide issue(s) of this PR:
Fixes #

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Installation
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

onecer
onecer reviewed Sep 15, 2022
View reviewed changes 8000
Copy link
Contributor
@onecer onecer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
codecov bot commented Sep 15, 2022 •
edited
Loading

Codecov Report

Merging #667 (fe3ed67) into main (5ee8cb1) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   53.21%   53.22%           
=======================================
  Files         164      164           
  Lines       23387    23387           
=======================================
+ Hits        12446    12448    +2     
+ Misses       8894     8893    -1     
+ Partials     2047     2046    -1
Impacted Files Coverage Δ
service/client.go 47.43% <ø> (ø)
store/boltdb/tool.go 100.00% <ø> (ø)
store/sqldb/tool.go 47.05% <ø> (ø)
cache/store_time.go 60.00% <66.66%> (ø)
cache/instance.go 75.89% <100.00%> (ø)
cache/service.go 83.40% <100.00%> (ø)
store/boltdb/handler.go 67.62% <0.00%> (-0.58%) ⬇️
store/sqldb/routing_config_v2.go 47.59% <0.00%> (+1.20%) ⬆️
cache/config_file.go 74.76% <0.00%> (+1.86%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

andrewshan
andrewshan reviewed Sep 17, 2022
View reviewed changes
@chuntaojun
Copy link
Member

pls fix ci

@lbbniu
Copy link
Contributor Author
lbbniu commented Sep 23, 2022

pls fix ci

pls run ci

@lbbniu lbbniu requested a review from chuntaojun September 23, 2022 10:16
@chuntaojun chuntaojun merged commit d30aaac into polarismesh:main Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onecer onecer onecer left review comments

@andrewshan andrewshan andrewshan left review comments

@chuntaojun chuntaojun Awaiting requested review from chuntaojun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lbbniu @chuntaojun @onecer @andrewshan
0