Local Storage Refactoring #300
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit: - Added Dexie as a dependency - Added support for typescript - Created a Dexie DB - Created the initial version of a podcast engine and DB access routines
…letion Started using the new local storage to show the list of podcasts. Added function to delete podcast from new local storage. Use the delete function on the list of podcasts.
|
Attempting to refactor an angular controller from function to class results in the following error: "angular.js:12477 TypeError: Class constructor PodcastsController cannot be invoked without 'new'" Related links:
I have worked it around by creating a function that calls the constructor. |
With this commit, last episodes view is now based on the new local storage - paging is working fine and fast. Some features are not working: - Link to all eps from podcast - Play - Add to / integration with playlist This is because the player and playlist still need to be refactored acording to the new local storage.
The episodes of a podcast are now loading episodes from the new local storage. Note the refactoring on the database indexes.
Refactored paged epsisodes logic, delating it to its own class.
Added to the description at the manifest.json file that podStation is open source.
…tion/podStation into enhancement#20__new-local-storage
Fixed error when showing the button "All episodes from <podcast title>".
Implemented toggle of playlist directly using AngularJS $broadcast. The state of the playlist visibility is not persisted and also no synchronized across different tabs (having different tabs is not common any way).
00c156c to
9fd5cc9
Compare
Cleaned up unused code for the playlist.
9fd5cc9 to
af335f1
Compare
Refactoring support for playing the next or previous episode based on player options, using the new local storage.
When updating a podcast, it was duplicating episode entries.
Moved OPML logic to the new podcast engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History
TODO
Testing
for sync storage testing: --user-data-dir (try to open two different instances logged in with the same user)
Lost functionality
socialnamespace (https://github.com/socialrss)Related issues
References