8000 [java] UnnecessaryLocalBeforeBranchRule by Pankraz76 · Pull Request #5835 · pmd/pmd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[java] UnnecessaryLocalBeforeBranchRule #5835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[java] UnnecessaryLocalBeforeBranchRule #5835

wants to merge 1 commit into from
+289 −35

Conversation

Pankraz76
Copy link
Contributor
@Pankraz76 Pankraz76 commented Jun 19, 2025 •
edited
Loading

prerequisite to fix imports:

Describe the PR

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@Pankraz76
Copy link
Contributor Author
Pankraz76 commented Jun 19, 2025 •
edited
Loading

need to fix imports...

[ERROR] src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/UnnecessaryLocalBeforeThrowRule.java:[15,1] (imports) ImportOrder: Wrong order for 'net.sourceforge.pmd.properties.PropertyFactory.booleanProperty' import.

@Pankraz76 Pankraz76 changed the title Unnecessary local before throw [java] UnnecessaryLocalBeforeThrowRule Jun 19, 2025
@Pankraz76 Pankraz76 mentioned this pull request Jun 19, 2025
Open
@Pankraz76 Pankraz76 force-pushed the UnnecessaryLocalBeforeThrow branch from ec64999 to 07e2497 Compare June 19, 2025 20:27
@Pankraz76 Pankraz76 marked this pull request as ready for review June 19, 2025 20:28
@github-actions GitHub Actions
Copy link

Documentation Preview

Compared to main:
This changeset changes 0 violations,
introduces 8 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.

Regression Tester Report

(comment created at 2025-06-19 20:49:42+00:00 for 07e2497)

@Pankraz76 Pankraz76 changed the title [java] UnnecessaryLocalBeforeThrowRule [java] UnnecessaryLocalBeforeBranchRule Jun 20, 2025
@Pankraz76 Pankraz76 force-pushed the UnnecessaryLocalBeforeThrow branch from 07e2497 to 9663264 Compare June 20, 2025 11:23
@Pankraz76
Copy link
Contributor Author

item:

pmd-java: Versions of archives indicate a minor change but binary incompatible changes found.

how to fix this please? assuming its related to new version since="7.15.0".

@oowekyala

@Pankraz76
Copy link
Contributor Author
Pankraz76 commented Jun 20, 2025 •
edited
Loading

should we give rewrite migration script for this, or does the license impose issues here as well?

im sure @iddeepak can grasp this very fast, like always, provide PoC.

@iddeepak
Copy link

should we give rewrite migration script for this, or does the license impose issues here as well?

im sure @iddeepak can grasp this very fast, like always, provide PoC.

Thanks @Pankraz76! I believe it depends on the implementation, since Rewrite is under the Moderne license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pankraz76 @iddeepak
0