8000 Add Rust CPD by juliapaluch · Pull Request #5414 · pmd/pmd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Rust CPD #5414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 27, 2024
Merged

Add Rust CPD #5414

merged 12 commits into from
Dec 27, 2024

Conversation

juliapaluch
Copy link
Contributor
@juliapaluch juliapaluch commented Dec 20, 2024 •
edited
Loading

Describe the PR

This PR adds CPD support for Rust.

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added the a:new-language Proposal to add a new PMD or CPD language to the main distribution label Dec 20, 2024
adangel
adangel reviewed Dec 20, 2024
View reviewed changes
Copy link
Member
@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Did you take the grammar from https://github.com/antlr/grammars-v4/tree/master/rust ? That's worth documenting somewhere, as languages evolve and grammars need to be kept up to date... so that we can update downstream/upstream if some parsing problem appears.

@juliapaluch
Copy link
Contributor Author

good point! I added a README to the directory where the grammar lives. I also deleted RustParser.g4 because I'm assuming that's unnecessary if we're just tokenizing. Please correct me if I'm wrong and I'll add it back!

@juliapaluch juliapaluch marked this pull request as draft December 20, 2024 19:47
@juliapaluch juliapaluch marked this pull request as ready for review December 20, 2024 23:59
jsotuyod
jsotuyod reviewed Dec 21, 2024
View reviewed changes
@ghost
Copy link
ghost commented Dec 21, 2024
1 Message
📖 No regression tested rules have been changed.

Generated by 🚫 Danger

@adangel adangel added this to the 7.9.0 milestone Dec 27, 2024
adangel
adangel approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member
@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

adangel added a commit that referenced this pull request Dec 27, 2024
@adangel
[doc] Update release notes (#5414)
c4c833a
@adangel adangel merged commit 4b773a0 into pmd:main Dec 27, 2024
3 checks passed
adangel added a commit that referenced this pull request Dec 27, 2024
@adangel
Add Rust CPD (#5414)
51767f3 
Merge pull request #5414 from juliapaluch:add-rust-cpd
adangel added a commit to pmd/pmd.github.io that referenced this pull request Dec 27, 2024
@adangel
Add Rust support
0c78d00 
Refs pmd/pmd#5414
@juliapaluch juliapaluch deleted the add-rust-cpd branch December 30, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsotuyod jsotuyod jsotuyod left review comments

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
a:new-language Proposal to add a new PMD or CPD language to the main distribution
Projects
None yet
Milestone
7.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@juliapaluch @jsotuyod @adangel
0