8000 Added missing files for patch 2996539 : Add support for C# to CPD (simple parser) by tiobe · Pull Request #5 · pmd/pmd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added missing files for patch 2996539 : Add support for C# to CPD (simple parser) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2012
Merged

Added missing files for patch 2996539 : Add support for C# to CPD (simple parser) #5

merged 1 commit into from
Nov 28, 2012

Conversation

tiobe
Copy link
@tiobe tiobe commented Aug 22, 2012

@ryan-gustafson
Copy link
Contributor

I started looking at this, and abandoned it after a while. I went off to see what it would take to get a real lexer for C# put in place. Still researching that.

While I do that, I think we can put this in as a stopgap. However, there are no tests for the CsTokenizer. I cannot commit this until there are.

@ghost ghost assigned rpelisse Nov 14, 2012
@adangel
Copy link
Member
adangel commented Nov 22, 2012

I think, we should commit this, as we already added half of the initial patch: 85cc2b5

Therefore I created a unit test for the tokenizer. See: https://github.com/adangel/pmd/compare/cstokenizer

I agree, that the CsTokenizer might not be the long term way to integrate C#. But until we find a real lexer/grammar for C#, I'm in favor of merging this pull request for 5.0.1.

@rpelisse
Copy link
Member

Me too.

I mean it's not the greatest feature ever, but it was kindly contributed,
it's probably working, at least to some extent, and it's not going to break
PMD. Morover, the rather limited implementation might trigger the will into
some other person to do a "full blown" parser...

On 22 November 2012 21:15, Andreas Dangel notifications@github.com wrote:

I think, we should commit this, as we already added half of the initial
patch: 85cc2b585cc2b5

Therefore I created a unit test for the tokenizer. See:
https://github.com/adangel/pmd/compare/cstokenizer

I agree, that the CsTokenizer might not be the long term way to integrate
C#. But until we find a real lexer/grammar for C#, I'm in favor of merging
this pull request for 5.0.1.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-10644050.

Romain PELISSE,
"The trouble with having an open mind, of course, is that people will
insist on coming along and trying to put things in it" -- Terry Pratchett
Belaran ins Prussia (blog) http://blog.wordpress.belaran.eu/ (...
finally up and running !)

@adangel adangel merged commit 3ceb80d into pmd:master Nov 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rpelisse rpelisse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiobe @ryan-gustafson @adangel @rpelisse
0