8000 adding a diverging bar example to the horizontal bar documentation by rl-utility-man · Pull Request #4994 · plotly/plotly.py · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding a diverging bar example to the horizontal bar documentation #4994

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

adding a diverging bar example to the horizontal bar documentation #4994

wants to merge 10 commits into from

Conversation

rl-utility-man
Copy link
Contributor

Documentation PR

  • [ Y ] I've seen the doc/README.md file
  • [ Yes, it works on 5.24.1 ] This change runs in the current version of Plotly on PyPI and targets the doc-prod branch OR it targets the master branch
  • [ N/A ] If this PR modifies the first example in a page or adds a new one, it is a px example if at all possible
  • [ Y ] Every new/modified example has a descriptive title and motivating sentence or paragraph
  • [ Y ] Every new/modified example is independently runnable
  • [ Y ] Every new/modified example is optimized for short line count and focuses on the Plotly/visualization-related aspects of the example rather than the computation required to produce the data being visualized
  • [ it's made up data with relatable labels ] Meaningful/relatable datasets are used for all new examples instead of randomly-generated data where possible
  • [ N/A ] The random seed is set if using randomly-generated data in new/modified examples
  • [ This is on our to do list. ] New/modified remote datasets are loaded from https://plotly.github.io/datasets and added to https://github.com/plotly/datasets
  • [ Y ] Large computations are avoided in the new/modified examples in favour of loading remote datasets that represent the output of such computations
  • [ Y ] Imports are plotly.graph_objects as go / plotly.express as px / plotly.io as pio
  • [ Y ] Data frames are always called df
  • [ Y ] fig = <something> call is high up in each new/modified example (either px.<something> or make_subplots or go.Figure)
  • [ Y ] Liberal use is made of fig.add_* and fig.update_* rather than go.Figure(data=..., layout=...) in every new/modified example
  • Specific adders and updaters like fig.add_shape and fig.update_xaxes are used instead of big fig.update_layout calls in every new/modified example
  • [ Y ] fig.show() is at the end of each new/modified example
  • [ Y ] plotly.plot() and plotly.iplot() are not used in any new/modified example
  • [ Y ] Hex codes for colors are not used in any new/modified example in favour of these nice ones

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

-->

@rl-utility-man
Copy link
Contributor Author

We are happy to pull out the xaxis section of update_layout and make it a separate call if you would prefer.

@gvwilson gvwilson requested a review from LiamConnors February 3, 2025 15:41
@gvwilson gvwilson added P2 considered for next cycle community community contribution documentation written for humans labels Feb 3, 2025
@rl-utility-man rl-utility-man mentioned this pull request Feb 6, 2025
Open
10 tasks
SimaRaha and others added 2 commits February 5, 2025 23:45
@SimaRaha @rl-utility-man
Update horizontal-bar-charts.md
3a3b7a8 
An example of a butterfly chart/diverging bar chart has been added.
@rl-utility-man
Rob's edits
6c2426a
@rl-utility-man
Copy link
Contributor Author

the only thing we changed is horizontal-bar-charts.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiamConnors LiamConnors Awaiting requested review from LiamConnors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community community contribution documentation written for humans P2 considered for next cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rl-utility-man @gvwilson @LiamConnors @SimaRaha
0