bugfix: one aggregate score per model + pin networkit==11.0.0 #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Ninjani
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For eval we use aggregate (weighed average or "wave") scores. In multi ligand systems we have them duplicated per each ligand entry.
Bug was introduced in PR#74 when dropping these duplicate values to avoid multiple counting for multi-ligand systems.
By accident this was dropping values from all the different ranks, too. Bug spotted by @DreRnc and reported in ISSUE #97
This PR should fix the above issue while maintaining the logic for multi ligand eval.
Additionally, with networkit new release 11.0.1 on Feb 13, 2025 -
test_make_components_and_communitiesfails.Temporarily add pin for the functional version:
networkit==11.0.0.