8000 Smetana is not supporting colors in UML · Issue #1702 · plantuml/plantuml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smetana is not supporting colors in UML #1702

Closed
martinviszlai opened this issue Feb 29, 2024 · 10 comments
Closed

Smetana is not supporting colors in UML #1702

martinviszlai opened this issue Feb 29, 2024 · 10 comments
Labels
enhancement New feature or request
8000

Comments

@martinviszlai
Copy link
martinviszlai commented Feb 29, 2024 •
edited by The-Lum
Loading

When using !pragma layout smetana, relation tags formatting is ignored.

Example of a simple diagram:

@startuml
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Container.puml

AddRelTag("API", $lineColor="red", $textColor="red", $lineStyle="dashed")

System(service, "service", "My awesome service")
System(client, "client", "Client service")

Rel(client, service, "make API calls", "HTTP", "calls methods from interfaces", $tags="API")
@enduml
@The-Lum The-Lum added enhancement New feature or request and removed triage labels Mar 7, 2024
@kirchsth
Copy link
Contributor
kirchsth commented May 9, 2024 •
edited by The-Lum
Loading

updated: I think smetana and ellk have the same skinparam related problem (skinparam ignored by arrows, and considered by e.g. rectangles)

Thank you and BR
Helmut

@The-Lum
Copy link
Collaborator
The-Lum commented May 13, 2024

Hello @arnaudroques, and all contributors,

Here is a minimal not working example:

@startuml
'!pragma layout smetana

<style>
.a {
  LineThickness 3
  Linecolor red
}
</style>

card a
a -> b <<a>>
@enduml
With GraphViz ✔️ With Smetana ❌

Observed on 1.2024.5beta1.

If that can help for debugging...
Regards,
Th.

@The-Lum
Copy link
Collaborator
The-Lum commented May 14, 2024

FYI, it is the logical continuation of:

@plantuml team:

  • Thanks for your [next] works

arnaudroques added a commit that referenced this issue May 23, 2024
@arnaudroques
fix: improve color support for UML diagrams using smetana layout
15170fe 
#1702
@The-Lum
Copy link
Collaborator
The-Lum commented May 23, 2024

@arnaudroques: Thank a lot for the correction.
I wouldn't have made it... Thank for your action.

[FYI @kirchsth]

Regards,
Th.

@The-Lum
Copy link
Collaborator
The-Lum commented May 24, 2024

FYI @kirchsth,

It is planned to deliver this correction in a next release scheduled for this weekend...
In order to plan on your side a new release of C4.

Regards,
Th.

@The-Lum
Copy link
Collaborator
The-Lum commented May 24, 2024

Sorry @arnaudroques:

  • Were you also able to look at the same type of issue but on the elk engine? 😃
@startuml
!pragma layout elk

<style>
.a {
  LineThickness 3
  Linecolor red
}
</style>

card a
a -> b <<a>>
@enduml

Currently, on the plantuml server, it seems that we observed: ClassNotFoundException...

Ref. :

@kirchsth
Copy link
Contributor
kirchsth commented May 27, 2024 •
edited
Loading

Currently, on the plantuml server, it seems that we observed: ClassNotFoundException...

It exists an issue for it: https://forum.plantuml.net/15676/layout-elk-fails-with-nullpointerexception?show=15676

@kirchsth
Copy link
Contributor

Hi @arnaudroques,

if you don't have a local version of the elk-full.jar file.
You can download it from http://beta.plantuml.net/elk-full.jar and put it parallel to your plantuml.jar that you have a working environment.

Thank you and best regards
Helmut

asm0dey pushed a commit to asm0dey/plantuml that referenced this issue Jun 5, 2024
@arnaudroques @asm0dey
fix: improve color support for UML diagrams using smetana layout
8000
161fdce 
plantuml#1702
@kirchsth
Copy link
Contributor

HI @arnaudroques,

I tried to merge the smetana fix to elk and during that I found out that the font color with smetana layout is not set, can you try to fix this too.

Thank you and BR Helmut

@kirchsth kirchsth mentioned this issue Jun 22, 2024
Merged
@The-Lum The-Lum mentioned this issue Jun 23, 2024
Closed
@kirchsth
Copy link
Contributor

Smetana/Elk and $FonColor are working in too snapshot (~v1.2024.6beta8) (details see mentions above), I think it can be closed.
BR Helmut

@The-Lum The-Lum closed this as completed Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martinviszlai @kirchsth @The-Lum
0