8000 pkp/pkp-lib#10263 Relax editing metadata on published/posted materials by Hafsa-Naeem · Pull Request #990 · pkp/ops · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

pkp/pkp-lib#10263 Relax editing metadata on published/posted materials #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main 8000
Choose a base branch
from
Open

pkp/pkp-lib#10263 Relax editing metadata on published/posted materials #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a4941f
pkp/pkp-lib#10263 Relax editing metadata on published/posted materials
Hafsa-Naeem May 27, 2025
97cbe1f
pkp/pkp-lib#10263 Submodule update ##Hafsa-Naeem/i10263-main-fix
Hafsa-Naeem May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions controllers/grid/preprintGalleys/PreprintGalleyGridHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,14 +488,24 @@ public function canEdit()
$submission = $this->getSubmission();
$userRoles = $this->getAuthorizedContextObject(Application::ASSOC_TYPE_USER_ROLES);

if ($publication->getData('status') === PKPSubmission::STATUS_PUBLISHED) {
return false;
}

if (in_array(Role::ROLE_ID_SITE_ADMIN, $userRoles)) {
return true;
}

// if it is published, allow managers or sub-editors
if ($publication->getData('status') === PKPSubmission::STATUS_PUBLISHED) {
// allow these roles to edit galleys even if published
if (
in_array(Role::ROLE_ID_MANAGER, $userRoles) ||
in_array(Role::ROLE_ID_SUB_EDITOR, $userRoles)
) {
return true;
}
// otherwise block
return false;
}

if ($submission->getData('dateSubmitted') == null) {
return true;
}
Expand Down
7 changes: 3 additions & 4 deletions cypress/tests/data/60-content/CmontgomerieSubmission.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,10 @@ describe('Data suite: Cmontgomerie', function() {
cy.wait(5000);

cy.openWorkflowMenu('Permissions & Disclosure& 10000 #39;);
cy.get('input[id^="publicationLicense-copyrightHolder-control-en"').clear()
cy.get('input[id^="publicationLicense-copyrightHolder-control-en"').type('Craig Montgomerie', {delay: 0});
cy.get('input[id^="publicationLicense-copyrightHolder-control-en"').clear();
cy.get('input[id^="publicationLicense-copyrightHolder-control-en"').type('Craig Montgomerie');
cy.get('button').contains('Save').click();
cy.get('[role="status"]').contains('Saved');
cy.wait(1500);
cy.wait(1500)

// Publish 2nd version
cy.get('button').contains('Post').click();
Expand Down
6 changes: 3 additions & 3 deletions cypress/tests/integration/Doi.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ describe('DOI tests', function() {
cy.get('button:contains("Post")').click();
cy.get('[data-cy="active-modal"] button:contains("Post")').click();

cy.get('div:contains("This version has been posted and can not be edited.")').should('exist');
cy.get('div:contains("Warning: This version has been published. Editing it may impact the published content.")').should('exist');

// Confirm DOI created for Version 1
// First publication assigns DOI as normal
Expand Down Expand Up @@ -365,7 +365,7 @@ describe('DOI tests', function() {

cy.get('button:contains("Post")').click();
cy.get('div.pkpWorkflow__publishModal button:contains("Post")').click();
cy.get('div:contains("This version has been posted and can not be edited.")').should('exist');
cy.get('div:contains("Warning: This version has been published. Editing it may impact the published content.")').should('exist');

// Confirm DOI carried over from Version 1 to Version 2
cy.visit('index.php/publicknowledge/dois');
Expand Down Expand Up @@ -506,7 +506,7 @@ describe('DOI tests', function() {

cy.get('button:contains("Post")').click();
cy.get('div.pkpWorkflow__publishModal button:contains("Post")').click();
cy.get('div:contains("This version has been posted and can not be edited.")').should('exist');
cy.get('div:contains("Warning: This version has been published. Editing it may impact the published content.")').should('exist');

// Confirm "current publication" DOI is new
cy.visit('index.php/publicknowledge/dois');
Expand Down
2 changes: 1 addition & 1 deletion lib/pkp
Open in desktop
Submodule pkp updated 84 files
+21 −36 api/v1/submissions/PKPSubmissionController.php
+0 −2 classes/author/Repository.php
+0 −2 classes/galley/Repository.php
+0 −6 classes/security/authorization/internal/RepresentationUploadAccessPolicy.php
+19 −5 classes/submission/Repository.php
+3 −0 classes/task/PublishSubmissions.php
+0 −3 controllers/grid/users/author/AuthorGridHandler.php
+2 −1 controllers/informationCenter/FileInformationCenterHandler.php
+3 −0 locale/an/admin.po
+3 −0 locale/an/api.po
+3 −0 locale/an/default.po
+2 −0 locale/an/emails.po
+3 −0 locale/an/grid.po
+3 −0 locale/an/manager.po
+3 −0 locale/an/reader.po
+3 −0 locale/an/reviewer.po
+3 −0 locale/an/submission.po
+2 −2 locale/ar/common.po
+11 −1 locale/ar/editor.po
+4 −1 locale/ar/grid.po
+4 −1 locale/ar/submission.po
+10 −2 locale/ar/user.po
+2 −2 locale/bg/common.po
+6 −1 locale/bg/submission.po
+6 −1 locale/cs/submission.po
+5 −5 locale/da/common.po
+6 −1 locale/da/submission.po
+6 −0 locale/en/submission.po
+2 −2 locale/es/common.po
+71 −13 locale/es/submission.po
+4 −4 locale/eu/common.po
+15 −8 locale/eu/reviewer.po
+45 −3 locale/fi/emails.po
+2,267 −3 locale/he/common.po
+634 −49 locale/he/user.po
+8 −8 locale/hy/common.po
+6 −1 locale/hy/submission.po
+55 −3 locale/id/admin.po
+14 −8 locale/id/common.po
+14 −3 locale/id/editor.po
+8 −4 locale/id/grid.po
+27 −2 locale/id/installer.po
+12 −7 locale/id/manager.po
+11 −5 locale/id/submission.po
+14 −5 locale/id/user.po
+2 −2 locale/mk/common.po
+6 −1 locale/mk/submission.po
+9 −6 locale/nl/admin.po
+13 −3 locale/nl/reviewer.po
+3 −3 locale/pt_BR/common.po
+12 −2 locale/pt_BR/editor.po
+7 −2 locale/pt_BR/submission.po
+13 −2 locale/pt_BR/user.po
+2 −2 locale/sl/common.po
+6 −1 locale/sl/submission.po
+4 −4 locale/uk/common.po
+6 −1 locale/uk/submission.po
+342 −258 locale/vi/admin.po
+183 −74 locale/vi/api.po
+439 −350 locale/vi/common.po
+238 −185 locale/vi/editor.po
+408 −156 locale/vi/emails.po
+119 −77 locale/vi/installer.po
+978 −888 locale/vi/manager.po
+7 −6 locale/vi/reader.po
+104 −39 locale/vi/reviewer.po
+1,186 −748 locale/vi/submission.po
+325 −132 locale/vi/user.po
+73 −50 locale/zh_Hans/admin.po
+43 −10 locale/zh_Hans/installer.po
+3 −0 locale/zh_Hans/reviewer.po
+6 −5 plugins/metadata/dc11/locale/vi/locale.po
+1 −1 templates/controllers/grid/settings/roles/form/userGroupForm.tpl
+1 −1 templates/controllers/notification/errorNotificationContent.tpl
+3 −1 templates/install/install.tpl
+2 −0 templates/install/upgrade.tpl
+2 −2 templates/management/tools/permissions.tpl
+2 −0 templates/plugins/importexport/innerResults.tpl
+2 −0 templates/plugins/importexport/resultsExport.tpl
+3 −0 templates/plugins/importexport/resultsImport.tpl
+1 −1 templates/stats/reports.tpl
+2 −2 templates/submission/cancelled.tpl
+2 −2 templates/submission/complete.tpl
+2 −1 templates/user/notificationSettingsForm.tpl
2 changes: 1 addition & 1 deletion lib/ui-library
Open in desktop
Submodule ui-library updated 12 files
+9 −4 src/components/Container/ManageEmailsPage.vue
+3 −16 src/components/ListPanel/contributors/ContributorsListPanel.vue
+0 −15 src/managers/GalleyManager/useGalleyManagerConfig.js
+8 −1 src/managers/ReviewerManager/useReviewerManagerConfig.js
+21 −5 src/pages/dashboard/composables/useDashboardConfigReviewActivity.js
+2 −0 src/pages/workflow/WorkflowPageOJS.vue
+2 −0 src/pages/workflow/WorkflowPageOMP.vue
+2 −0 src/pages/workflow/WorkflowPageOPS.vue
+13 −0 src/pages/workflow/components/publication/WorkflowPublicationEditWarning.vue
+2 −1 src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOJS.js
+11 −4 src/pages/workflow/composables/useWorkflowPermissions.js
+53 −0 src/styles/_global.less
0