pkp/pkp-lib#10962 Map contextAcronym to journalAcronym in the email template installer #4898
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitaliy-1
requested changes
May 27, 2025
There was a problem hiding this comment.
Thanks @Hafsa-Naeem , but that's only for upgrade to 3.4, right? That's also should be run by users, who already updated to 3.4.
88b5224 to
243aee8
Compare
Vitaliy-1
requested changes
Jun 3, 2025
dbscripts/xml/upgrade.xml
Outdated
| @@ -125,6 +125,7 @@ | |||
| <upgrade minversion="3.4.0.0" maxversion="3.4.9.9"> | |||
| <migration class="APP\migration\upgrade\v3_4_0\I9813_QuickSubmitSubmissionProgressType"/> | |||
| <migration class="APP\migration\upgrade\v3_5_0\I11241_MissingDecisionConstantsUpdate"/> | |||
| <migration class="APP\migration\upgrade\v3_4_0\I7264_UpdateEmailTemplates"/> | |||
There was a problem hiding this comment.
I'm worrying about running the whole script the second time.
E.g., we can extend PKP\migration\upgrade\v3_4_0\I7264_UpdateEmailTemplates and override up() and down() method only for iterating through email templates and replacing needed variable.
There was a problem hiding this comment.
The new migration class will be added for the 3.4.0.0 - 3.4.9.9 instead of the old one.
c9ee21b to
d0f5ed4
Compare
…emplate installer
…o rename legacy contextAcronym → journalAcronym for existing 3.4 installs
…EQUEST and update variable map
d0f5ed4 to
575b133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10962