8000 Fix windows and unsupported platform builds with dummy values by harshavardhana · Pull Request #40 · pkg/xattr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ xattr Public
  • < 8000 a href="/login?return_to=%2Fpkg%2Fxattr" rel="nofollow" id="repository-details-watch-button" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"notification subscription menu watch","repository_id":null,"auth_type":"LOG_IN","originating_url":"https://github.com/pkg/xattr/pull/40","user_id":null}}" data-hydro-click-hmac="e2d4876fd2d640b73482381365a1a02ccbde96a816ea11655282d676e049a5a9" aria-label="You must be signed in to change notification settings" data-view-component="true" class="btn-sm btn"> Notifications You must be signed in to change notification settings
  • Fork 30
  • Star 181

Fix windows and unsupported platform builds with dummy values #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2019
Merged

Fix windows and unsupported platform builds with dummy values #40

merged 1 commit into from
Mar 26, 2019

Conversation

harshavardhana
Copy link
Contributor

To fix https://travis-ci.org/minio/mc/jobs/511289483

# github.com/pkg/xattr
..\..\..\..\pkg\mod\github.com\pkg\xattr@v0.4.0\xattr.go:40:10: undefined: getxattr
..\..\..\..\pkg\mod\github.com\pkg\xattr@v0.4.0\xattr.go:47:10: undefined: lgetxattr
..\..\..\..\pkg\mod\github.com\pkg\xattr@v0.4.0\xattr.go:54:10: undefined: fgetxattr
..\..\..\..\pkg\mod\github.com\pkg\xattr@v0.4.0\xattr.go:106:12: undefined: setxattr
..\..\..\..\pkg\mod\github.com\pkg\xattr@v0.4.0\xattr.go:115:12: undefined: lsetxattr
..\..\..\..\pkg\mod\github.com\pkg\xattr@v0.4.0\xattr.go:123:12: undefined: fsetxattr
..\..\..\..\pkg\mod\github.com\pkg\xattr@v0.4.0\xattr.go:132:12: undefined: setxattr
..\..\..\..\pkg\mod\github.com\pkg\xattr@v0.4.0\xattr.go:141:12: undefined: lsetxattr
..\..\..\..\pkg\mod\github.com\pkg\xattr@v0.4.0\xattr.go:149:12: undefined: fsetxattr
..\..\..\..\pkg\mod\github.com\pkg\xattr@v0.4.0\xattr.go:157:12: undefined: removexattr
..\..\..\..\pkg\mod\github.com\pkg\xattr@v0.4.0\xattr.go:157:12: too many errors
The command "go build --ldflags="$(go run buildscripts/gen-ldflags.go)" -o %GOPATHin\mc.exe" exited with 2.

@codecov-io
Copy link
codecov-io commented Mar 26, 2019 •
edited
Loading

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #40   +/-   ##
======================================
  Coverage    89.3%   89.3%           
======================================
  Files           3       3           
  Lines         159     159           
======================================
  Hits          142     142           
  Misses         11      11           
  Partials        6       6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7782c2d...0d0ae8d. Read the comment docs.

@kuba--
Copy link
Member
kuba-- commented Mar 26, 2019

@harshavardhana - thanks for PR.
Tests are failing on Linux/Darwin - could you fix .travis file (you left extra }):

0.02s$ if [[ "${TRAVIS_OS_NAME}" != "windows" ]]; then diff <(goimports -d .) <(printf "") }; fi
diff: extra operand `}'
diff: Try `diff --help' for more information.
The command "if [[ "${TRAVIS_OS_NAME}" != "windows" ]]; then diff <(goimports -d .) <(printf "") }; fi" exited with 2.

Also it makes sense to extend travis.sh file, adding windows build.

@harshavardhana
Copy link
Contributor Author

Done thanks @kuba--

@kuba-- kuba-- merged commit dd870b5 into pkg:master Mar 26, 2019
@harshavardhana harshavardhana deleted the unsupported branch March 26, 2019 20:27
@harshavardhana
Copy link
Contributor Author

Can you tag a release @kuba-- pretty please?

@harshavardhana
Copy link
Contributor Author

Can you tag a release @kuba-- pretty please?

Oops you already did.. Thanks 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuba-- kuba-- kuba-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshavardhana @codecov-io @kuba--
0