8000 fix: bitmap text emoji render by rnike · Pull Request #11275 · pixijs/pixijs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: bitmap text emoji render #11275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 9, 2025
Merged

fix: bitmap text emoji render #11275

merged 4 commits into from
May 9, 2025

Conversation

rnike
Copy link
Contributor
@rnike rnike commented Feb 12, 2025 •
edited
Loading
Description of change

fix #11166, some emojis(consists of multiple code points) are not correctly rendered in BitmapText

Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@rnike rnike changed the title fix: bitmap text emoji color fix: bitmap text emoji render Feb 12, 2025
@codesandbox-ci CodeSandbox CI
Copy link
codesandbox-ci bot commented Feb 12, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Zyie Zyie requested a review from GoodBoyDigital May 4, 2025 13:38
@GoodBoyDigital
Merge branch 'dev' into pr/11275
6ae7921
@GoodBoyDigital
feat: add bitmap text emoji scene and corresponding snapshots
a839541 
- Introduced a new test scene for rendering bitmap text with emojis.
- Added snapshot images for WebGL1, WebGL2, and WebGPU to validate rendering output.
@GoodBoyDigital
refactor: optimize segment handling in CanvasTextMetrics
f04bf15 
- Improved the segment extraction logic in the CanvasTextMetrics class by replacing the spread operator with a more explicit loop for better performance and clarity.
- This change enhances the readability of the code while maintaining the same functionality.
GoodBoyDigital
GoodBoyDigital approved these changes May 8, 2025
View reviewed changes
Copy link
Member
@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I added a test + optimised the graphemeSegmenter function a tad!

@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label May 9, 2025
@Zyie Zyie added this pull request to the merge queue May 9, 2025
Merged via the queue into pixijs:dev with commit 9161e30 May 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoodBoyDigital GoodBoyDigital GoodBoyDigital approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: some emojis in BitmapText are not correctly rendered
3 participants
@rnike @GoodBoyDigital @Zyie
0