Update gprofiler to latest upstream code #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: slicklash <slicklash@gmail.com> Co-authored-by: Oren de Lame <oren.delame@granulate.io>
* Changed verify_precondictions to print message when not root and not exit. Added run_in_ns_wrapper to only run in namespace when root is detected. Updated pgrep_maps to provide parameter that ignores permission errors when not root. * Added function for mkdir_owned_user and used it when creating gprofiler_tmp directory. Added pids_to_process to discover_appropriate_perf_event(), so it will not error out on perf record -a while not root. Changed TEMPORARY_STORAGE_PATH to the resources directory. * Added --rootless parameter as an opt-in for running sudoless. Removed is_root function (now in granulate-utils). Added mkdir_owned_root_wrapper. Moved TEMPORARY_STORAGE_PATH back to /tmp. pgrep_maps root check now inside function * Check that tmp directory is writeable if it already exists when trying os.mkdir. Also some linting. * granulate-utils submodule updated * Update test_not_root with new exit string --------- Co-authored-by: sobolron <58514213+sobolron@users.noreply.github.com>
Co-authored-by: awherr <Adam Herr>
* The patch is created by Ron Sobol to support build on VPN network Signed-off-by: Min Lim <min.yeol.lim@intel.com> * Enable the proxy workaround as build option Signed-off-by: Min Lim <min.yeol.lim@intel.com> * Revised the patch to remove duplicated code Signed-off-by: Min Lim <min.yeol.lim@intel.com> * Fix for linting as something is parsed differently with in hadolint. Plus remove boilerplate. --------- Signed-off-by: Min Lim <min.yeol.lim@intel.com> Co-authored-by: Ron Sobol <ron.sobol@granulate.io>
…rsion (#947) * Added documentation for rootless feature in README.md and iterated version in __init__.py for release * Rootless doc changes per review * Remove version iteration from __init__.py (to try to address test failures)
* Make aarch build to run on all PRs * add containerd.io removal to builder preparation * Reinsert the requirement for tag ref when building aarch64 container as it also pushes it
* Update ubuntu version to latest in builds, and fix permission issues we know we have. * Try to split yum lines to try and avoid installation issues * Add yum clean all to all, and update centos image to latest centos7. * Fix linting and try to understand why retry doesn't work well * Try to fix installation issues with retries... * Update pyspy version because it fails on new python versions * Update rust builder to support newer pyspy * Upgrade rust version in aarch as well... * Split rbspy and pyspy builders as last resort * Add trace to failing script * Upgrade libunwind dep to latest stable (1.8.1) * Use python 3.10 version which is really supported (latest, probably 3.10.17 when writing this) * Change permissions mechanis to just add permissions for all users to containers files * Try again to fix permissions issues * Add prints to try and debug the issue * Remove the permissions preexec_fn to see if this was the issue * Add ruby installation step to tests job as latest linux version ruby is not supported by current rbspy * Fix bug in retry sh scripts that don't return 0 if succeeded after 2nd try or more * Set host ruby version for container tests as well * Update java versions for hotspot test issues, make sure to find correct symbols on newer glibc versions * Fix java app metadata test for after changing java container used * Fix missing socket test after fixed in newer java versions * Remove missing DSO test as it seems like libc changed in new version, and it works the same as one test above...
* Upgrade python version support (3.10+) * Fix python 3.9 to 3.10 in few places * Fix ContextManager typing for 3.10 AND 3.13. * Try upgrading to newest exe requirements * Try to patch around the use of staticx to maybe find something that works here. * Removed staticx_patch as the code for it was changed in JonathonReinhart/staticx@6fcecfa * Fix staticx issues, with scons and with PyInstaller issues * Try to fix RUNPATH issues... Not sure this will be OK. * Add patchelf installation to commands for dotnet-trace installations * Fix dotnet-trace elf path for build * Remove bad pip install line * Fix things related to staticx usage in pyperf build * Fix issue for linter * Fix issue for Docker linter * Fix typo in staticx run * Move some code to maintain AARCH64 support (without pyperf) * Fix staticx installation in x86_64 to include the correct code, and make sure that it has the required prerequisits. * Added new setuptools after issues with build after rebase * Try fixing things using better exe-requirements and better build deps for staticx * Update staticx revision with fixes. * Fix bad addition of --always. * Fix issue with isolated env doesn't have scons * Add fix for gprofiler halts when creating new processes in another pgroup. * Add missing python versions to runtime image listing for tests * Update bpf_get_stack_offset code to fix for kernel 6.9+ with TOP_OF_KERNEL_STACK_PADDING when CONFIG_X86_FRED is set * Add retries for curl for various errors * Update bpf_get_stack_offset with fix * Fix bcc pyperf to support python 3.13 * Allow metadata to find python version for 3.13 * Update bcc version, hopefully with offsets fixed * Update pyperf to where I fixed offsets again after looking it up dynamically * Update bcc after fixing offsets and code logic for python 3.12 and 3.13 * Update bcc with small fixes for verifier * Update bcc with fixes for python <3.11 * Put pyperf verbosity on in tests * Revert change made to use var_count as it seems it doesn't work for classes * Attempt to add bp to allow better symbol resolution for native frames. * Downgrade ubuntu for tests to see if it helps * Increase pyperf timeouts to make tests pass * Revert "Increase pyperf timeouts to make tests pass" as it didn't help This reverts commit a28d8d4. * Reduce pyperf verbosity as it blocks stderr. don't check native stacks on python 3.12 * Increase pyperf pipesize to make sure it doesn't halt because of it * Update python3.10 dockerfile to multiarch. Update tests accordingly --------- Co-authored-by: slicklash <slicklash@gmail.com>
* Switch the namespace from granulate to intel Signed-off-by: Min Lim <min.yeol.lim@intel.com> * Restore the burn repo to granulate Signed-off-by: Min Lim <min.yeol.lim@intel.com> * Additional changes needed Signed-off-by: Min Lim <min.yeol.lim@intel.com> * Resolve the linter issues Signed-off-by: Min Lim <min.yeol.lim@intel.com> --------- Signed-off-by: Min Lim <min.yeol.lim@intel.com>
* Remove granulate.io links due to service shutdown Signed-off-by: Min Lim <min.yeol.lim@intel.com> * Update based on review comment Signed-off-by: Min Lim <min.yeol.lim@intel.com> --------- Signed-off-by: Min Lim <min.yeol.lim@intel.com>
prashantbytesyntax
approved these changes
May 6, 2025
* Initial POC for perfspect integration Signed-off-by: Min Lim <min.yeol.lim@intel.com> * Fix python linter issues Signed-off-by: Min Lim <min.yeol.lim@intel.com> * Remove the existing files when collection starts Signed-off-by: Min Lim <min.yeol.lim@intel.com> * Revised based on review comments Signed-off-by: Min Lim <min.yeol.lim@intel.com> --------- Signed-off-by: Min Lim <min.yeol.lim@intel.com>
Signed-off-by: Min Lim <min.yeol.lim@intel.com>
* Create codeql.yml for SDL * Remove scan for unused languages * Try adding SDL report generation * Update upload-artifact version * Make reports unique * Fix bug in uploader * Fix bug in uploader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update gprofiler to latest upstream code