8000 expression: refine invalid char error msg for string conversion by Defined2014 · Pull Request #59711 · pingcap/tidb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: refine invalid char error msg for string conversion #59711

Merged
merged 7 commits into from
Feb 25, 2025
Merged

expression: refine invalid char error msg for string conversion #59711

merged 7 commits into from
Feb 25, 2025
+55 −29

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #56706

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2025
@tiprow tiprow
Copy link
tiprow bot commented Feb 24, 2025

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I 8000 understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link
tiprow bot commented Feb 24, 2025

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2025
@codecov Codecov
Copy link
codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.2339%. Comparing base (a5d433a) to head (5dd3a64).
Report is 12 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #59711        +/-   ##
================================================
+ Coverage   72.9537%   73.2339%   +0.2801%     
================================================
  Files          1697       1697                
  Lines        468912     470349      +1437     
================================================
+ Hits         342089     344455      +2366     
+ Misses       105752     104817       -935     
- Partials      21071      21077         +6
Flag Coverage Δ
integration 42.7718% <85.7142%> (?)
unit 72.1542% <35.7142%> (+0.0053%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.1219% <ø> (+0.0225%) ⬆️

zimulala
zimulala approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor
@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 25, 2025
@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link
tiprow bot commented Feb 25, 2025

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 25, 2025
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Feb 25, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-25 01:42:46.388466468 +0000 UTC m=+320114.341624719: ☑️ agreed by zimulala.
  • 2025-02-25 07:15:54.540817885 +0000 UTC m=+340102.493976151: ☑️ agreed by XuHuaiyu.

@Defined2014
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2025
@Defined2014 Defined2014 reopened this Feb 25, 2025
@ti-chi-bot ti-chi-bot bot removed the approved label Feb 25, 2025
@Defined2014
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2025
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, XuHuaiyu, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 25, 2025
@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link
tiprow bot commented Feb 25, 2025

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link
tiprow bot commented Feb 25, 2025

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 4cf94a7 into pingcap:master Feb 25, 2025
22 checks passed
@Defined2014 Defined2014 deleted the fix-56706 branch February 25, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message: Unexpected line break
4 participants
@Defined2014 @zimulala @XuHuaiyu @tangenta
0