8000 ttl: set a result for timeout scan task during shrinking scan worker (#57718) by ti-chi-bot · Pull Request #57828 · pingcap/tidb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttl: set a result for timeout scan task during shrinking scan worker (#57718) #57828

Merged
merged 2 commits into from
Jan 7, 2025
Merged

ttl: set a result for timeout scan task during shrinking scan worker (#57718) #57828

merged 2 commits into from
Jan 7, 2025

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57718

What problem does this PR solve?

Issue Number: close #57708

Problem Summary:

The result is not set for the scan task when TiDB is shrinking the scan worker and timeout.

What changed and how does it work?

Set a result for the scan task.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
set a result for timeout scan task
30a4736 
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot
fix the timer assert of systemTZ
7831552 
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 29, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 29, 2024
Merged
13 tasks
@codecov Codecov
Copy link
codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.5@43b21d4). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-8.5     #57828   +/-   ##
================================================
  Coverage               ?   56.8645%           
================================================
  Files                  ?       1770           
  Lines                  ?     626622           
  Branches               ?          0           
================================================
  Hits                   ?     356326           
  Misses                 ?     246217           
  Partials               ?      24079
Flag Coverage Δ
integration 36.8310% <0.0000%> (?)
unit 72.5570% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.2398% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 6, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
YangKeao
YangKeao approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member
@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Jan 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-07 06:54:44.320232067 +0000 UTC m=+250227.609063771: ☑️ agreed by lcwangchao.
  • 2025-01-07 07:16:51.876173681 +0000 UTC m=+251555.165005389: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot merged commit b454755 into pingcap:release-8.5 Jan 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees
No one assigned
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @lcwangchao @YangKeao
0