[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: provide a system view cluster_tidb_plan_cache to allow users to see the cluster's Plan Cache Info #57781

Merged
merged 2 commits into from
Nov 28, 2024
Merged

planner: provide a system view cluster_tidb_plan_cache to allow users to see the cluster's Plan Cache Info #57781

merged 2 commits into from
Nov 28, 2024

Conversation

qw4990
Copy link
Contributor
@qw4990 qw4990 commented Nov 28, 2024

What problem does this PR solve?

Issue Number: ref #54057

Problem Summary: planner: provide a system view cluster_tidb_plan_cache to allow users to see the cluster's Plan Cache Info

What changed and how does it work?

mysql> select * from information_schema.cluster_tidb_plan_cache\G
*************************** 1. row ***************************
        INSTANCE: 127.0.0.1:10080
      SQL_DIGEST: e5796985ccafe2f71126ed6c0ac939ffa015a8c0744a24b7aee6d587103fd2f7
        SQL_TEXT: select * from t
       STMT_TYPE: Select
      PARSE_USER: root
     PLAN_DIGEST: ccb0d7dbb386cbf97a7007105f4b9f48d79db972766c84bfba32e55df7ffede8
     BINARY_PLAN: wAFYCr0BCg1UYWJsZVJlYWRlcl81EmoKD1QBEVBGdWxsU2Nhbl80IQEAAAA4DU9BKQABAdiIw0A4AkACSgsKCQoEVEVTVBIBdFIea2VlcCBvcmRlcjpmYWxzZSwgc3RhdHM6cHNldWRvcP//DQIEAXgNCSj//wEhVVVVVZUjEx1ZKAFAAVIUZGF0YTpUNoUAAHAZNyh4////////////AQ==
         BINDING: 
         OPT_ENV: fa40491c2d37f137ecaefe68699bc30e649245edfe999a81729f84f9cdd5d2e7
    PARSE_VALUES: 
        MEM_SIZE: 4998
      EXECUTIONS: 2
  PROCESSED_KEYS: 0
      TOTAL_KEYS: 2
     SUM_LATENCY: 7365876
       LOAD_TIME: 2024-11-28 14:18:08
LAST_ACTIVE_TIME: 2024-11-28 14:18:08
*************************** 2. row ***************************
        INSTANCE: 127.0.0.1:10081
      SQL_DIGEST: e5796985ccafe2f71126ed6c0ac939ffa015a8c0744a24b7aee6d587103fd2f7
        SQL_TEXT: select * from t
       STMT_TYPE: Select
      PARSE_USER: root
     PLAN_DIGEST: ccb0d7dbb386cbf97a7007105f4b9f48d79db972766c84bfba32e55df7ffede8
     BINARY_PLAN: wAFYCr0BCg1UYWJsZVJlYWRlcl81EmoKD1QBEVBGdWxsU2Nhbl80IQEAAAA4DU9BKQABAdiIw0A4AkACSgsKCQoEdGVzdBIBdFIea2VlcCBvcmRlcjpmYWxzZSwgc3RhdHM6cHNldWRvcP//DQIEAXgNCSj//wEhVVVVVZUjEx1ZNAFAAVIUZGF0YTpUYWJsHYUAcBk3KHj///////////8B
         BINDING: 
         OPT_ENV: e869fe7b8a196b0ef75453c9b92d3f67cf4b1f638bab22eb8ba26a16160d3577
    PARSE_VALUES: 
        MEM_SIZE: 4998
      EXECUTIONS: 2
  PROCESSED_KEYS: 0
      TOTAL_KEYS: 2
     SUM_LATENCY: 6261791
       LOAD_TIME: 2024-11-28 14:17:30
LAST_ACTIVE_TIME: 2024-11-28 14:17:31
2 rows in set (0.00 sec)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2024
@tiprow tiprow
Copy link
tiprow bot commented Nov 28, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2024
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Nov 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-28 06:46:03.626950495 +0000 UTC m=+705351.246605013: ☑️ agreed by hawkingrei.
  • 2024-11-28 06:47:10.691691341 +0000 UTC m=+705418.311345855: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 28, 2024
@codecov Codecov
Copy link
codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.7207%. Comparing base (924784a) to head (e1fbf0a).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #57781        +/-   ##
================================================
+ Coverage   72.8642%   74.7207%   +1.8564%     
================================================
  Files          1677       1722        +45     
  Lines        464210     472351      +8141     
================================================
+ Hits         338243     352944     +14701     
+ Misses       105090      97186      -7904     
- Partials      20877      22221      +1344
Flag Coverage Δ
integration 49.2004% <0.0000%> (?)
unit 72.2268% <62.5000%> (-0.0333%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 61.1876% <ø> (+15.5020%) ⬆️

@tiprow tiprow
Copy link
tiprow bot commented Nov 28, 2024

@qw4990: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow e1fbf0a link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit fb7e32f into pingcap:master Nov 28, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@AilinKid AilinKid AilinKid approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @hawkingrei @AilinKid @tangenta