8000 planner: fix the issue that Update on partition tables can't hit the Instance Plan Cache by qw4990 · Pull Request #57787 · pingcap/tidb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix the issue that Update on partition tables can't hit the Instance Plan Cache #57787

Merged
merged 1 commit into from
Nov 28, 2024
Merged

planner: fix the issue that Update on partition tables can't hit the Instance Plan Cache #57787

merged 1 commit into from
Nov 28, 2024

Conversation

qw4990
Copy link
Contributor
@qw4990 qw4990 commented Nov 28, 2024

What problem does this PR solve?

Issue Number: close #57726, ref #54057

Problem Summary: planner: fix the issue that Update on partition tables can't hit the Instance Plan Cache

What changed and how does it work?

planner: fix the issue that Update on partition tables can't hit the Instance Plan Cache

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 28, 2024
@tiprow tiprow
Copy link
tiprow bot commented Nov 28, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link
codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5917%. Comparing base (fb7e32f) to head (b4626c3).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #57787        +/-   ##
================================================
+ Coverage   72.8219%   73.5917%   +0.7698%     
================================================
  Files          1677       1677                
  Lines        464216     465177       +961     
================================================
+ Hits         338051     342332      +4281     
+ Misses       105273     102129      -3144     
+ Partials      20892      20716       -176
Flag Coverage Δ
integration 43.6002% <ø> (?)
unit 72.4130% <ø> (+0.1908%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7276% <ø> (+0.0300%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2024
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2024
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Nov 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-28 08:26:17.379081901 +0000 UTC m=+711364.998736418: ☑️ agreed by AilinKid.
  • 2024-11-28 08:41:57.541776648 +0000 UTC m=+712305.161431180: ☑️ agreed by hawkingrei.

@qw4990
Copy link
Contributor Author
qw4990 commented Nov 28, 2024

/test unit-test

@tiprow tiprow
Copy link
tiprow bot commented Nov 28, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit c9a8f1f into pingcap:master Nov 28, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

partition can't use the instance plan cache
3 participants
@qw4990 @hawkingrei @AilinKid
0