executor: fix query infoschema.tables table_schema/table_name with filter condition (#57746) #57771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57771 +/- ##
================================================
Coverage ? 57.2301%
================================================
Files ? 1770
Lines ? 628894
Branches ? 0
================================================
Hits ? 359917
Misses ? 244939
Partials ? 24038
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tangenta
approved these changes
Nov 28, 2024
tiancaiamao
approved these changes
Nov 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #57746
What problem does this PR solve?
Issue Number: close #57657
Problem Summary:
What changed and how does it work?
There is a special optimize that if the result columns for query on INFORMATION_SCHEMA.TABLES only contains
table_schematable_name, all the data are in-memory, then we have a special code path for such case #55574But that code path differ from the main code path and miss some filter conditions, so it cause the bug in issue #57657
This fix will make the special optimize check more strick.
Only the queries for
table_nametable_schemacolumns AND WITHOUT OTHER FILTER CONDITIONS run to the special optimization.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.