[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, runtime_filter: Remove redundant logs whose meaning can be directly displayed by default behavior (#57626) #57633

Open
wants to merge 1 commit into
base: release-8.5
Choose a base branch
from
Open

planner, runtime_filter: Remove redundant logs whose meaning can be directly displayed by default behavior (#57626) #57633

wants to merge 1 commit into from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57626

What problem does this PR solve?

Issue Number: close #57625

Problem Summary:

What changed and how does it work?

Runtime Filter generator is log the warning message when it cannot generator a RF for a hash join. But RF could not support Tidb hash join by default
Since this type of log will be printed in TiDB in large quantities, as long as query is TiDB hash joins, I decided to delete this log directly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 22, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Nov 22, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link
codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.5@d2978bc). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-8.5     #57633   +/-   ##
================================================
  Coverage               ?   56.8214%           
================================================
  Files                  ?       1770           
  Lines                  ?     626445           
  Branches               ?          0           
================================================
  Hits                   ?     355955           
  Misses                 ?     246368           
  Partials               ?      24122
Flag Coverage Δ
integration 36.8743% <ø> (?)
unit 72.4748% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.2820% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 26, 2024
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, Rustin170506

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 26, 2024
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Nov 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-26 02:39:42.368686098 +0000 UTC m=+517769.988340614: ☑️ agreed by Rustin170506.
  • 2024-11-26 02:43:41.529570558 +0000 UTC m=+518009.149225060: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Nov 26, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees

@elsa0520 elsa0520

Labels
approved do-not-merge/cherry-pick-not-approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @AilinKid @Rustin170506 @elsa0520