*: bump client-go with some regression tests #57282

you06 · 2024-11-11T06:42:34Z

What problem does this PR solve?

Issue Number: ref #55287, close #56837, ref #57338, close #57425

Problem Summary:

What changed and how does it work?

Introduce the chunk comparison of common prefix (amd64 and arm64 only), which can accelerate a lot for indexes with very wide columns.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2024-11-11T06:42:53Z

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-11-11T07:24:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.1365%. Comparing base (a22b842) to head (b58330a).
Report is 88 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #57282        +/-   ##
================================================
+ Coverage   72.8488%   73.1365%   +0.2876%     
================================================
  Files          1672       1676         +4     
  Lines        462666     471279      +8613     
================================================
+ Hits         337047     344677      +7630     
- Misses       104821     105657       +836     
- Partials      20798      20945       +147

Flag	Coverage Δ
integration	`43.5259% <86.3636%> (?)`
unit	`72.2152% <100.0000%> (-0.0065%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.7673% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`43.2710% <ø> (-1.8516%)`	⬇️

ref pingcap#53127 handle key-too-large error from MemBuffer Signed-off-by: you06 <you1474600@gmail.com> test MemBuffer's oversize error to tidb error Signed-off-by: you06 <you1474600@gmail.com> update errdoc Signed-off-by: you06 <you1474600@gmail.com>

Signed-off-by: you06 <you1474600@gmail.com>

pkg/store/driver/txn/driver_test.go

Signed-off-by: you06 <you1474600@gmail.com>

you06 · 2024-11-20T05:15:27Z

/retest

tiprow · 2024-11-20T05:15:48Z

@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pkg/executor/mem_reader.go

ti-chi-bot · 2024-11-20T05:19:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, ekexium

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cfzjywxk,ekexium]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-11-20T05:19:23Z

[LGTM Timeline notifier]

Timeline:

2024-11-18 08:10:37.684484498 +0000 UTC m=+862199.875353492: ☑️ agreed by ekexium.
2024-11-20 05:19:22.527742454 +0000 UTC m=+8950.147396966: ☑️ agreed by cfzjywxk.

cfzjywxk · 2024-11-20T05:19:30Z

/ok-to-test

Signed-off-by: you06 <you1474600@gmail.com>

you06 · 2024-11-20T09:52:57Z

/retest

Signed-off-by: you06 <you1474600@gmail.com>

you06 · 2024-11-20T11:09:16Z

/retest

ti-chi-bot · 2024-11-20T12:33:05Z

In response to a cherrypick label: new pull request created to branch release-8.5: #57563.

ref #55287, close #56837, ref #57338, close #57425

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2024-11-27T07:19:05Z

In response to a cherrypick label: new pull request created to branch release-8.1: #57761.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> resolve conflict Signed-off-by: you06 <you1474600@gmail.com> fix pr Signed-off-by: you06 <you1474600@gmail.com>

ti-chi-bot · 2024-11-27T08:43:28Z

In response to a cherrypick label: new pull request created to branch release-6.5: #57763.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2024-11-27T08:43:32Z

In response to a cherrypick label: new pull request created to branch release-7.1: #57764.

ti-chi-bot · 2024-11-27T08:43:32Z

In response to a cherrypick label: new pull request created to branch release-7.5: #57765.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> resolve conflict Signed-off-by: you06 <you1474600@gmail.com> fix pr Signed-off-by: you06 <you1474600@gmail.com>

Signed-off-by: you06 <you1474600@gmail.com>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2024

wshwsh12 and others added 2 commits November 18, 2024 16:35

update client-go and add regression test

2e79a1a

Signed-off-by: you06 <you1474600@gmail.com>

you06 force-pushed the client-go/art-opt branch from 02c96c9 to 2e79a1a Compare November 18, 2024 07:46

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2024

you06 changed the title *: bump client-go to improve the performance of ART *: bump client-go with some regression tests Nov 18, 2024

you06 requested review from cfzjywxk and ekexium November 18, 2024 07:50

update bazel

8b41898

Signed-off-by: you06 <you1474600@gmail.com>

ekexium approved these changes Nov 18, 2024

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 18, 2024

cfzjywxk reviewed Nov 18, 2024

View reviewed changes

pkg/store/driver/txn/driver_test.go Outdated Show resolved Hide resolved

ekexium linked an issue Nov 19, 2024 that may be closed by this pull request

data race in TestPipelinedDMLInsertOnDuplicateKeyUpdateInTxn #57213

Closed

you06 added 3 commits November 20, 2024 13:20

update client-go

93f332f

Signed-off-by: you06 <you1474600@gmail.com>

explicitly close snapshot iterator

af8b4f3

Signed-off-by: you06 <you1474600@gmail.com>

fix lint

85406bd

Signed-off-by: you06 <you1474600@gmail.com>

cfzjywxk approved these changes Nov 20, 2024

View reviewed changes

pkg/executor/mem_reader.go Show resolved Hide resolved

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 20, 2024

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 20, 2024

you06 added 2 commits November 20, 2024 18:09

fix test

d08c5ff

Signed-off-by: you06 <you1474600@gmail.com>

guarantee the read ts can see schema

9541ba0

Signed-off-by: you06 <you1474600@gmail.com>

you06 added 2 commits November 20, 2024 19:10

fix test

a22f433

Signed-off-by: you06 <you1474600@gmail.com>

fix test

b58330a

Signed-off-by: you06 <you1474600@gmail.com>

ti-chi-bot bot merged commit e234164 into pingcap:master Nov 20, 2024
24 checks passed

ti-chi-bot mentioned this pull request Nov 20, 2024

*: bump client-go with some regression tests (#57282) #57563

Merged

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Nov 21, 2024

*: bump client-go with some regression tests (#57282) (#57563)

9862e83

ref #55287, close #56837, ref #57338, close #57425

you06 added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Nov 27, 2024

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024

This is an automated cherry-pick of pingcap#57282

8e37db5

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Nov 27, 2024

*: bump client-go with some regression tests (#57282) #57761

Open

13 tasks

you06 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Nov 27, 2024

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024

This is an automated cherry-pick of pingcap#57282

6c843ea

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Nov 27, 2024

*: bump client-go with some regression tests (#57282) #57763

Open

13 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024

This is an automated cherry-pick of pingcap#57282

91436c8

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024

This is an automated cherry-pick of pingcap#57282

33e2b5c

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

This was referenced Nov 27, 2024

*: bump client-go with some regression tests (#57282) #57764

Open

*: bump client-go with some regression tests (#57282) #57765

Open

you06 added a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024

pick pingcap#57282

5fea8ad

Signed-off-by: you06 <you1474600@gmail.com>

you06 added a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024

pick pingcap#57282

a197bc6

Signed-off-by: you06 <you1474600@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: bump client-go with some regression tests #57282

*: bump client-go with some regression tests #57282

*: bump client-go with some regression tests #57282

*: bump client-go with some regression tests #57282

Conversation

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Codecov Report

[LGTM Timeline notifier]