statistics: handle the prune mode correctly in the refresher #57096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #57096 +/- ##
=================================================
- Coverage 73.2121% 57.2470% -15.9651%
=================================================
Files 1652 1809 +157
Lines 456143 653936 +197793
=================================================
+ Hits 333952 374359 +40407
- Misses 101669 254719 +153050
- Partials 20522 24858 +4336
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/retest |
Rustin170506
commented
Nov 4, 2024
100d379
to
15ead73
Compare
Signed-off-by: Rustin170506 <29879298+Rustin170506@users.noreply.github.com>
15ead73
to
e0ab534
Compare
13 tasks
qw4990
approved these changes
Nov 5, 2024
AilinKid
approved these changes
Nov 5, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Rustin170506
added a commit
to Rustin170506/tidb
that referenced
this pull request
Nov 6, 2024
13 tasks
|
In response to a cherrypick label: new pull request created to branch |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #57168
Problem Summary:
What changed and how does it work?
When checking the prune mode, we need to ensure that we have loaded the latest variable value. However, directly using the system session pool does not work, as it requires manual updates to obtain the latest global variable value.
In this PR, I utilized the session context from the caller that has already updated the session, allowing us to correctly retrieve the prune mode.
For earlier versions of TiDB, this issue did not occur because we did not use this session to retrieve the global variable in those versions.
Additionally, I added a test case for the queue to verify the handling of DML changes for partitioned tables.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.