8000 fix sql condition being skipped when exporting objects in grid by pfilipkowskilemon · Pull Request #13663 · pimcore/pimcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix sql condition being skipped when exporting objects in grid #13663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2022
Merged

fix sql condition being skipped when exporting objects in grid #13663

merged 2 commits into from
Dec 7, 2022

Conversation

pfilipkowskilemon
Copy link
Contributor
@pfilipkowskilemon pfilipkowskilemon commented Nov 23, 2022 •
edited
Loading

Changes in this pull request

Resolves #
#13662

Additional info

Resolves issue with skipping sql condition when exporting to csv in grid

@CLAassistant
Copy link
CLAassistant commented Nov 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
github-actions bot commented Nov 23, 2022 •
edited by Corepex
Loading

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@pfilipkowskilemon pfilipkowskilemon mentioned this pull request Nov 23, 2022
Closed
@robertSt7 robertSt7 closed this Nov 23, 2022
@robertSt7 robertSt7 reopened this Nov 23, 2022
@mcop1 mcop1 assig 8000 ned Corepex Nov 28, 2022
@Corepex Corepex added this to the 10.5.12 milestone Nov 29, 2022
@Corepex Corepex added the Bug label Nov 29, 2022
@Corepex
Copy link
Contributor
Corepex commented Nov 30, 2022

@pfilipkowskilemon, thanks for your PR. I tested your solution, and it worked correctly, but I maybe found another way that fixes the this.sqlFilter. I think it would be a cleaner solution to add this.sqlFilter = field.getValue() to gridTabAbstract.js#L181. In this case, this.sqlFilter will be set on "submitting" the filter input.

https://github.com/pimcore/pimcore/blob/10.6/bundles/AdminBundle/Resources/public/js/pimcore/object/helpers/gridTabAbstract.js#L181

@mcop1 mcop1 linked an issue Dec 5, 2022 that may be closed by this pull request
[Bug]: Sql condition is skipped when exporting to csv in grid #13662
Closed
@Corepex
Copy link
Contributor
Corepex commented Dec 7, 2022

@pfilipkowskilemon friendly reminder - if you provide the changes, we could add them to today's release

@pfilipkowskilemon
Copy link
Contributor Author

@Corepex thanks for reminder

@Corepex Corepex merged commit a067c31 into pimcore:10.5 Dec 7, 2022
@Corepex
Copy link
Contributor
Corepex commented Dec 7, 2022 •
edited
Loading

@pfilipkowskilemon, thanks for helping us to improve pimcore 👍

@Maksonis Maksonis mentioned this pull request Dec 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Corepex Corepex

Labels
Bug
Projects
None yet
Milestone
10.5.12
Development

Successfully merging this pull request may close these issues.

[Bug]: Sql condition is skipped when exporting to csv in grid
4 participants
@pfilipkowskilemon @CLAassistant @Corepex @robertSt7
0