8000 [Documents] Fix inheritance for editables in a dialog box by dvesh3 · Pull Request #12811 · pimcore/pimcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Documents] Fix inheritance for editables in a dialog box #12811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2022
Merged

[Documents] Fix inheritance for editables in a dialog box #12811

merged 1 commit into from
Aug 3, 2022

Conversation

dvesh3
Copy link
Contributor
@dvesh3 dvesh3 commented Aug 2, 2022

Changes in this pull request

Resolves #12775

Additional info

@dvesh3 dvesh3 added the Bug label Aug 2, 2022
@dvesh3 dvesh3 added this to the 10.5.1 milestone Aug 2, 2022
@github-actions
Copy link
github-actions bot commented Aug 2, 2022 •
edited by kingjia90
Loading

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90 kingjia90 self-assigned this Aug 2, 2022
@kingjia90 kingjia90 linked an issue Aug 2, 2022 that may be closed by this pull request
[Bug]: When saving a document with inherited areas, the editables in the settings dialog are saved, even if not overridden #12775
Closed
@kingjia90 kingjia90 merged commit 5bf7298 into 10.5 Aug 3, 2022
@kingjia90 kingjia90 deleted the fix_documents_editables_dialog_box branch August 3, 2022 10:26
@kingjia90 kingjia90 mentioned this pull request Aug 3, 2022
Closed
@dvesh3 dvesh3 mentioned this pull request Aug 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kingjia90 kingjia90

Labels
Bug
Projects
None yet
Milestone
10.5.1
Development

Successfully merging this pull request may close these issues.

[Bug]: When saving a document with inherited areas, the editables in the settings dialog are saved, even if not overridden
2 participants
@dvesh3 @kingjia90
0