8000 Fix: Missing Video Thumbnails won't be generated by blankse · Pull Request #12697 · pimcore/pimcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Missing Video Thumbnails won't be generated #12697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2022
Merged

Fix: Missing Video Thumbnails won't be generated #12697

merged 3 commits into from
Jul 20, 2022

Conversation

blankse
Copy link
Contributor
@blankse blankse commented Jul 20, 2022 •
edited
Loading

We have the problem that video thumbnails are missing but in the thumbnail cache. I don't know how the thumbnails are deleted.

The getHtml5Code() method will generate a auto thumbnail name. But when this is in the cache no config will stored in the TmpStore.

The PublicServiceController can so not load the thumbnail config. I would delete the thumbnail from cache in this case.

Maybe related: #12549

@github-actions
Copy link
github-actions bot commented Jul 20, 2022 •
edited by dvesh3
Loading

Review Checklist

  • Target branch (10.4 for bug fixes, others 10.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@dvesh3 dvesh3 added the Bug label Jul 20, 2022
@dvesh3 dvesh3 added this to the 10.4.6 milestone Jul 20, 2022
@blankse blankse mentioned this pull request Jul 20, 2022
Merged
@dvesh3 dvesh3 self-assigned this Jul 20, 2022
@dvesh3
Copy link
Contributor
dvesh3 commented Jul 20, 2022

@blankse sorry, I'm not able to reproduce the issue. If i delete generated thumbnail files then these are re-generated on next load.

@blankse
Copy link
Contributor Author
blankse commented Jul 20, 2022

@dvesh3 Do you use the pimcore_video Editable? Without "imagethumbnail" option?

@blankse
Copy link
Contributor Author
blankse commented Jul 20, 2022

@dvesh3 In the backend it works. Its only in frontend.

@dvesh3
Copy link
Contributor
dvesh3 commented Jul 20, 2022

yes, I can reproduce the problem on frontend and your changes fixes the issue.

@dvesh3 dvesh3 merged commit f83e388 into pimcore:10.4 Jul 20, 2022
@dvesh3
Copy link
Contributor
dvesh3 commented Jul 20, 2022

@blankse thanks!

@blankse blankse deleted the fix_missing_video_thumbnails_not_generated branch July 20, 2022 13:30
@kingjia90 kingjia90 mentioned this pull request Jul 24, 2022
Closed
This was referenced Aug 5, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dvesh3 dvesh3

Labels
Bug
Projects
None yet
Milestone
10.4.6
Development

Successfull 3961 y merging this pull request may close these issues.
2 participants
@blankse @dvesh3
0