8000 Allow customizations by ctippler · Pull Request #114 · pimcore/output-data-config-toolkit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow customizations #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2024
Merged

Allow customizations #114

merged 2 commits into from
Mar 22, 2024

Conversation

ctippler
Copy link
Contributor
@ctippler ctippler commented Mar 6, 2024

This PR issues following features:

  • Make also ConfigElement\Value classes extendable (same logic as it is for Config\Element\Operator)
  • Fix the order of class names which are checked (first we need to check the App specific classes, and then the classes from the Bundles (otherwise we cannot get the extended version) )
  • move the logic to get the values from the classification store to an own method (so it is easier to overwrite)

ctippler and others added 2 commits March 6, 2024 21:44
@ctippler
- Make also "Value" Classes extendable (same logic as for operators)
bf93aba 
- move logic for classification store getter to own method to make it easier to overwrite

- Fix logic vor class loading (first check app specific folders - then the the regular one)
@ctippler @github-actions
Apply php-cs-fixer changes 8000
449d033
@ghost ghost added the Pimcore:ToDo label Mar 12, 2024
@markus-moser markus-moser added this to the v5.1.0 milestone Mar 22, 2024
@markus-moser markus-moser self-requested a review March 22, 2024 08:23
@markus-moser markus-moser self-assigned this Mar 22, 2024
@markus-moser markus-moser removed their request for review March 22, 2024 08:24
@markus-moser markus-moser merged commit 957eeac into pimcore:5.x Mar 22, 2024
@markus-moser
Copy link
Contributor

LGTM - thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@markus-moser markus-moser

Labels
Improvement
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ctippler @markus-moser
0