[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow gitlab ci to be detected #3670

Open
wants to merge 1 commit into
base: 1.12.x
Choose a base branch
from
Open

Allow gitlab ci to be detected #3670

wants to merge 1 commit into from

Conversation

BackEndTea
Copy link
Contributor

Gitlab CI wasn't being detected by the CiDetectedErrorFormatter. This MR allows detection so that the CiDetectedErrorFormatter can be used for gitlab as well.

@ondrejmirtes
Copy link
Member

AFAIK GitLab still only shows these results in paid tiers: https://docs.gitlab.com/ee/ci/testing/code_quality.html

That's why GitLab CI is not currently detected by default. Maybe it's part of GITLAB_FEATURES env variable, I'm not sure. If you research that and detect correctly then I'd merge that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BackEndTea @ondrejmirtes