8000 Replace uses of PHP_EOL with "\n" by MatmaRex · Pull Request #12 · phpactor/test-utils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Replace uses of PHP_EOL with "\n" #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2024
Merged

Replace uses of PHP_EOL with "\n" #12

merged 1 commit into from
Mar 1, 2024

Conversation

MatmaRex
Copy link
Contributor
@MatmaRex MatmaRex commented Mar 1, 2024

@MatmaRex
Copy link
Contributor Author
MatmaRex commented Mar 1, 2024

This fixes about 300 test failures in phpactor/phpactor on Windows, it's used in the setup for lots of tests and it just didn't work.

@dantleech dantleech merged commit 5655428 into phpactor:master Mar 1, 2024
@dantleech
Copy link
Contributor

🙇

@MatmaRex MatmaRex mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatmaRex @dantleech
0