8000 Getters for response, status code and others · Issue #58 · php-mod/curl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Getters for response, status code and others #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jormaechea opened this issue Nov 27, 2018 · 1 comment
Closed

Getters for response, status code and others #58

jormaechea opened this issue Nov 27, 2018 · 1 comment
Labels
accepting pull request

Comments

@jormaechea
Copy link
Contributor

It would be nice to have some more getters, so I don't depend on the object properties, and also mock this lib properly in my projects.
For tests, it's cleaner to mock methods than just setting the $curl->response property, for example.

The following getters would be appreciated:

public function getResponse(); // Returns response prop

public function getErrorCode(); // Returns curl_error_code prop

public function getErrorMessage(); // Returns curl_error_message prop

public function getHttpStatus(); // Returns http_status_code prop

Of course I could build a wrapper for this, but then I'd have two dependencies for something as simple as making a request.
jormaechea added a commit to jormaechea/curl that referenced this issue Dec 4, 2018
@jormaechea
Getters added (php-mod#58)
0dd4b99
amouhzi pushed a commit that referenced this issue Dec 4, 2018
@jormaechea @amouhzi
Getters added (#58) (#59)
d22086d
@amouhzi
Copy link
Member
amouhzi commented Dec 4, 2018

Fixed #59

@amouhzi amouhzi closed this as completed Dec 4, 2018
@evilangelmd evilangelmd mentioned this issue Dec 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepting pull request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amouhzi @jormaechea
0