10000 Warnings receive higher priority than errors · Issue #20 · phindle/error-lens · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Warnings receive higher priority than errors #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
georgebonnr opened this issue Feb 21, 2019 · 1 comment
Open

Warnings receive higher priority than errors #20

georgebonnr opened this issue Feb 21, 2019 · 1 comment
Assignees
@phindle
Labels
bug Something isn't working

Comments

@georgebonnr
Copy link

If a warning level error is present on a given line, it becomes the displayed errorLens message in place of an error level error that may be present on the same line.

Example:

  1. A serious error is present
    image
  2. I make a change that triggers a warning on the same line (in this case the warning is coming from Prettier, but other warnings trigger the same behavior)
    image
  3. I am informed about the warning, but don't know that a more severe error is also present.

With the default error messaging styles in VSCode, it would be easy to see that both an error and a warning are present on the same line, but with the full-line highlighting I believe we need to be thoughtful about the hierarchy of which error is displayed.

Proposal: Priority order of ['error', 'warning', 'info', 'hint']. This could also be user configurable.
@phindle phindle self-assigned this Feb 22, 2019
@phindle phindle added the bug Something isn't working label Feb 22, 2019
@phindle
Copy link
Owner
phindle commented Feb 22, 2019

Thanks for spotting this, feels like a bug, so I'll ensure errors are always prioritised.

ypresto pushed a commit to ypresto/error-lens that referenced this issue May 14, 2022
@usernamehw
Add new outlined gutter icon set. Fixes phindle#20
152894a 
Also rename all svg files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phindle phindle

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@georgebonnr @phindle
0