fix: db guc set supports quoted param #345
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons to the guc_value portion of the ALTER SYSTEM SET SQL in order to support spaced, quoted guc values \n PLAT-44
jason-lynch
reviewed
Jul 2, 2025
| pg_v, spock_v = util.get_pg_v() | ||
| pg = pg_v[2:] | ||
|
|
||
| nc = "./pgedge " | ||
| ncb = nc + "pgbin " + str(pg) + " " | ||
|
|
||
| cmd = f"ALTER SYSTEM SET {guc_name} = {guc_value}" | ||
| cmd = f"ALTER SYSTEM SET {guc_name} = '{guc_value}'" |
There was a problem hiding this comment.
Nice find! This looks like it solves the immediate issue. Since we're quoting the string, we should also consider escaping single quotes and backslashes in guc_value. In order to do that, you double any single-quote or backslash characters in the string. Patroni does this in an elegant way with a regex: https://github.com/patroni/patroni/blob/1ee6c5a651d2ebc30a698a7b9859177674571291/patroni/postgresql/config.py#L298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an extra set of quotations to the guc_value portion of the ALTER SYSTEM SET SQL in order to support spaced, quoted guc values.
PLAT-44